checking in homework#7
Open
tthaman wants to merge 1 commit into
Open
Conversation
…ast homepage it was on
tthaman
changed the title
Author
|
Couldn't get the detail page to return to the correct page, unless the character is on the first page |
t1mwillis
reviewed
Jun 10, 2020
| const [name, setName] = useState(''); | ||
| const [birthyear, setBirthyear] = useState(''); | ||
|
|
||
| let {idx} = useParams(); |
There was a problem hiding this comment.
Nice! I might use something besides idx, maybe id?
t1mwillis
reviewed
Jun 10, 2020
|
|
||
| fetch(homeworldUrl) | ||
| .then(res => res.json()) | ||
| .then(data => setHomeworld(data.name)); |
There was a problem hiding this comment.
I would drop a catch in here, just in case...
t1mwillis
reviewed
Jun 10, 2020
| starships: PropTypes.array, | ||
| created: PropTypes.string, | ||
| edited: PropTypes.string, | ||
| url: PropTypes.string, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ast homepage it was on
Week 5 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.