From 20260d69008ec8a7661c0d85a6843968079fdbd2 Mon Sep 17 00:00:00 2001 From: Nick Richards Date: Tue, 11 Sep 2018 13:50:12 -0400 Subject: [PATCH] Fix Tool configuration file dialog when selecting XRNS2XMOD Shell exe - Use file extension instead of full filename to configure dialog - Seen on MacOS 10.13.6 / Renoise 3.1.1 64b - Affirmed by Renoise API documentation http://files.renoise.com/xrnx/documentation/Renoise.Application.API.lua.html ``` Opens a modal dialog to query a filename and path to read from a file. The given extension(s) should be something like {"wav", "aiff" or "*" (any file) } renoise.app():prompt_for_filename_to_read({file_extensions}, dialog_title) -> [filename or empty string] ``` - Make more explicit the configuration file dialog's textual instructions --- control_panel_gui.lua | 2 +- globals.lua | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/control_panel_gui.lua b/control_panel_gui.lua index 89f80c6..1fed7b4 100644 --- a/control_panel_gui.lua +++ b/control_panel_gui.lua @@ -90,7 +90,7 @@ function show_controlpanel_dialog() width = 30, notifier = function() - local exe_file = renoise.app():prompt_for_filename_to_read({XRNS2XMOD_EXE}, "Locate Xrns2XMod Path"); + local exe_file = renoise.app():prompt_for_filename_to_read({XRNS2XMOD_EXE_EXTENSION}, "Locate Xrns2XMod executable: e.g. Xrns2XModShell.exe"); local is_app_found = #exe_file > 0 diff --git a/globals.lua b/globals.lua index 447ed4c..99d8dd4 100644 --- a/globals.lua +++ b/globals.lua @@ -14,7 +14,7 @@ -- the notifications.app_new_document functions or in your action callbacks... XRNS2XMOD_URL = "https://github.com/fstarred/xrns2xmod/"; -XRNS2XMOD_EXE = "Xrns2XModShell.exe"; +XRNS2XMOD_EXE_EXTENSION = "exe"; XRNS2XMOD_DOC_URL = "https://github.com/fstarred/xrns2xmod/wiki"; XRNS2XMOD_TUTORIAL_VIDEO_URL = "http://www.youtube.com/playlist?list=PLZZHTXBWLnp8L60rT10UOZCqe0m5J9Uyr"; XRNS2XMOD_VERSION_INFO_URL = 'http://starredmediasoft.com/xrns2xmod_updater.xml'