Commit 5f49d5b
committed
Address second round of review feedback
- Replace Number.isFinite with Number.isInteger in concurrentMap validation:
floats like 1.5 now correctly throw RangeError (isInteger implies finite,
covers NaN/Infinity/floats/negatives in a single check)
- Add test: concurrency=1.5 throws RangeError
- Pass maxRetries=0 to fetchWithRetry for raw file fetches so AbortSignal.timeout
acts as a strict hard cap; retry delays in fetchWithRetry are not abort-aware
and would otherwise let a timed-out request silently retry for up to 30 s
See: #1001 parent c00b14d commit 5f49d5b
3 files changed
Lines changed: 14 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
364 | 364 | | |
365 | 365 | | |
366 | 366 | | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
367 | 373 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | | - | |
| 128 | + | |
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
229 | 229 | | |
230 | 230 | | |
231 | 231 | | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
236 | 239 | | |
237 | 240 | | |
238 | 241 | | |
| |||
0 commit comments