fix(highlight): address Copilot review comments on PR #80

- detectLang: perform extension map lookup before Dockerfile check to
  prevent false positives (e.g. Dockerfile.ts correctly detected as
  TypeScript, Dockerfile.php as PHP)
- PHP tokenizer: use /^#(?!\[)[^\n]*/ for hash comments to avoid
  dimming PHP 8+ attribute syntax (#[Route], #[ORM\Entity], etc.)
- Test: assert \x1b[35m magenta on Terraform boolean/null literals
  (was only checking text preservation via strip())
- Test: add MAINTAINER to Dockerfile instructions test (present in
  regex but was missing from test list)
- Test: add regression for Dockerfile.ts → typescript detection
- Test: add PHP 8+ attribute non-comment assertion

Author: shouze

src/render/highlight.test.ts

@@ -525,6 +525,15 @@ describe("PHP tokenizer", () => {
     expect(strip(highlightFragment("# comment", [], "f.php").join(""))).toBe("# comment");
   });
 
+  it("does NOT dim PHP 8+ attribute syntax #[...] as a comment", () => {
+    // Without the fix, '#[Route(...)]' is consumed as a single dim comment token.
+    // With the fix, '#' falls through to the default dim rule, but 'Route'
+    // is recognised as a PascalCase identifier → cyan (not part of a comment).
+    const out = highlightFragment("#[Route('/')]", [], "f.php").join("");
+    expect(out).toContain("\x1b[36m"); // cyan for PascalCase 'Route' — proves it's NOT swallowed by the comment rule
+    expect(strip(out)).toBe("#[Route('/')]");
+  });
+
   it("colorizes block comments", () => {
     expect(strip(highlightFragment("/* block */", [], "f.php").join(""))).toBe("/* block */");
   });
@@ -679,7 +688,9 @@ describe("Terraform/HCL tokenizer", () => {
 
   it("colorizes boolean literals", () => {
     for (const kw of ["true", "false", "null"]) {
-      expect(strip(highlightFragment(kw, [], "f.tf").join(""))).toBe(kw);
+      const out = highlightFragment(kw, [], "f.tf").join("");
+      expect(out).toContain("\x1b[35m"); // magenta for boolean/null literals
+      expect(strip(out)).toBe(kw);
     }
   });
 
@@ -706,6 +717,14 @@ describe("Dockerfile tokenizer", () => {
     expect(out).toContain("\x1b[35m"); // pc.magenta for instructions
   });
 
+  it("does NOT mis-detect 'Dockerfile.ts' as Dockerfile — extension wins", () => {
+    // 'const' is a TypeScript keyword → magenta via TS rules, not Dockerfile rules.
+    // The key assertion is that the extension-based lookup takes priority.
+    const out = highlightFragment("const", [], "Dockerfile.ts").join("");
+    expect(out).toContain("\x1b[35m"); // magenta via TypeScript keywords, not Dockerfile
+    expect(strip(out)).toBe("const");
+  });
+
   it("colorizes all standard Dockerfile instructions in magenta", () => {
     for (const instr of [
       "FROM",
@@ -725,6 +744,7 @@ describe("Dockerfile tokenizer", () => {
       "STOPSIGNAL",
       "HEALTHCHECK",
       "SHELL",
+      "MAINTAINER", // deprecated but still present in the regex
     ]) {
       const out = highlightFragment(instr, [], "Dockerfile").join("");
       expect(out).toContain("\x1b[35m"); // magenta

src/render/highlight.ts

@@ -23,13 +23,8 @@ type Lang =
   | "text";
 
 function detectLang(filePath: string): Lang {
-  // Dockerfile detection by filename (no extension)
-  const base = filePath.split("/").pop() ?? "";
-  const baseLower = base.toLowerCase();
-  if (baseLower === "dockerfile" || baseLower.startsWith("dockerfile.")) {
-    return "dockerfile";
-  }
-
+  // Extension-based detection takes priority to avoid false positives
+  // (e.g. Dockerfile.ts must be detected as typescript, not dockerfile).
   const ext = filePath.split(".").pop()?.toLowerCase() ?? "";
   const map: Record<string, Lang> = {
     ts: "typescript",
@@ -71,7 +66,18 @@ function detectLang(filePath: string): Lang {
     tf: "terraform",
     hcl: "terraform",
   };
-  return map[ext] ?? "text";
+  const langFromExt = map[ext];
+  if (langFromExt) return langFromExt;
+
+  // Dockerfile detection by filename — only reached when no extension matched,
+  // so Dockerfile.ts / Dockerfile.php are never misidentified.
+  const base = filePath.split("/").pop() ?? "";
+  const baseLower = base.toLowerCase();
+  if (baseLower === "dockerfile" || baseLower.startsWith("dockerfile.")) {
+    return "dockerfile";
+  }
+
+  return "text";
 }
 
 // ─── Syntax token rules ───────────────────────────────────────────────────────
@@ -199,7 +205,8 @@ const tokenRules: Partial<Record<Lang, TokenRule[]>> & {
   ],
   php: [
     [/^\/\/[^\n]*/, (s) => pc.dim(s)],
-    [/^#[^\n]*/, (s) => pc.dim(s)],
+    // Fix: exclude PHP 8+ attribute syntax (#[Route(...)], #[ORM\Entity]) from being dimmed as comments
+    [/^#(?!\[)[^\n]*/, (s) => pc.dim(s)],
     [/^\/\*[\s\S]*?\*\//, (s) => pc.dim(s)],
     [/^"(?:[^"\\]|\\.)*"/, (s) => pc.green(s)],
     [/^'(?:[^'\\]|\\.)*'/, (s) => pc.green(s)],