lint: type check failures in main

[JimFuller-RedHat]

running against main branch > make lint-all I get some type check failures

make lint-all
pre-commit run --all-files
check yaml...............................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
detect private key.......................................................Passed
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check json...............................................................Passed
check toml...............................................................Passed
mixed line ending........................................................Passed
ruff (legacy alias)......................................................Passed
ruff format..............................................................Passed
ty check.................................................................Failed
- hook id: ty
- exit code: 1

Installed 1 package in 13ms
error[invalid-argument-type]: Argument to constructor `Path.__new__` is incorrect
   --> experiments/agent-scoped-tools-triage/tools/agent-runner/agent_runner_server.py:120:26
    |
120 |         working_dir=Path(working_dir),
    |                          ^^^^^^^^^^^ Expected `str | PathLike[str]`, found `str | None`
    |
info: element `None` of union `str | None` is not assignable to `str | PathLike[str]`
info: └── type `None` is not assignable to any element of the union `str | PathLike[str]`
info:     ├── type `None` is not assignable to protocol `PathLike[str]`
info:     │   └── protocol member `__fspath__` is not defined on type `None`
info:     └── ... omitted 1 union element without additional context
info: Function defined here
   --> stdlib/pathlib/__init__.pyi:308:13
    |
308 |         def __new__(cls, *args: StrPath, **kwargs: Unused) -> Self: ...  # pyright: ignore[reportInconsistentConstructor]
    |             ^^^^^^^      -------------- Parameter declared here
    |

error[invalid-argument-type]: Argument to `AgentRunner.__init__` is incorrect
   --> experiments/agent-scoped-tools-triage/tools/agent-runner/agent_runner_server.py:121:9
    |
121 |         owner=owner,
    |         ^^^^^^^^^^^ Expected `str`, found `str | None`
    |
info: element `None` of union `str | None` is not assignable to `str`
info: Method defined here
   --> experiments/agent-scoped-tools-triage/tools/agent-runner/runner.py:124:9
    |
124 |     def __init__(
    |         ^^^^^^^^
125 |         self,
126 |         working_dir: Path,
127 |         owner: str,
    |         ---------- Parameter declared here
    |

error[invalid-argument-type]: Argument to `AgentRunner.__init__` is incorrect
   --> experiments/agent-scoped-tools-triage/tools/agent-runner/agent_runner_server.py:122:9
    |
122 |         repo_name=repo_name,
    |         ^^^^^^^^^^^^^^^^^^^ Expected `str`, found `str | None`
    |
info: element `None` of union `str | None` is not assignable to `str`
info: Method defined here
   --> experiments/agent-scoped-tools-triage/tools/agent-runner/runner.py:124:9
    |
124 |     def __init__(
    |         ^^^^^^^^
125 |         self,
126 |         working_dir: Path,
127 |         owner: str,
128 |         repo_name: str,
    |         -------------- Parameter declared here
    |

error[invalid-argument-type]: Argument to constructor `int.__new__` is incorrect
   --> experiments/agent-scoped-tools-triage/tools/agent-runner/agent_runner_server.py:123:26
    |
123 |         issue_number=int(issue_number),
    |                          ^^^^^^^^^^^^ Expected `str | Buffer | SupportsInt | SupportsIndex | SupportsTrunc`, found `str | None`
    |
info: element `None` of union `str | None` is not assignable to `str | Buffer | SupportsInt | SupportsIndex | SupportsTrunc`
info: └── type `None` is not assignable to any element of the union `str | Buffer | SupportsInt | SupportsIndex | SupportsTrunc`
info:     ├── type `None` is not assignable to protocol `Buffer`
info:     │   └── protocol member `__buffer__` is not defined on type `None`
info:     ├── type `None` is not assignable to protocol `SupportsInt`
info:     │   └── protocol member `__int__` is not defined on type `None`
info:     ├── type `None` is not assignable to protocol `SupportsIndex`
info:     │   └── protocol member `__index__` is not defined on type `None`
info:     ├── type `None` is not assignable to protocol `SupportsTrunc`
info:     │   └── protocol member `__trunc__` is not defined on type `None`
info:     └── ... omitted 1 union element without additional context
info: Matching overload defined here
   --> stdlib/builtins.pyi:366:9
    |
366 |     def __new__(cls, x: ConvertibleToInt = 0, /) -> Self: ...
    |         ^^^^^^^      ----------------------- Parameter declared here
    |
info: Non-matching overloads for function `__new__`:
info:   [Self](cls, x: str | bytes | bytearray, /, base: SupportsIndex) -> Self

Found 4 diagnostics

bandit...................................................................Passed
Detect hardcoded secrets.................................................Passed
Lint GitHub Actions workflow files.......................................Passed
go vet...................................................................Passed
lint ADR statuses........................................................Passed
lint ADR numbers.........................................................Passed
lint ADR frontmatter.....................................................Passed
lint broken symlinks.....................................................Passed
make: *** [Makefile:63: lint-all] Error 1

[rh-hemartin]

/triage

[fullsend-ai-triage]

Triage Summary

Severity: Medium | Category: Bug

Problem

The ty check pre-commit hook fails on main with 4 type errors in agent_runner_server.py (lines 120–123). Four variables (working_dir, owner, repo_name, issue_number) have type str | None but are passed to functions requiring non-optional types.

Root Cause Hypothesis

These variables are likely sourced from environment variables or optional parameters that return str | None. They are passed directly to Path() and AgentRunner.__init__() without None-guards, which the ty type checker correctly flags as unsafe.

Recommended Fix

Add explicit None-checks before line 120 in agent_runner_server.py. For example, raise a ValueError with a descriptive message if any required variable is None:

for name, val in [("working_dir", working_dir), ("owner", owner),
                   ("repo_name", repo_name), ("issue_number", issue_number)]:
    if val is None:
        raise ValueError(f"Required parameter '{name}' is not set")

runner = AgentRunner(
    working_dir=Path(working_dir),
    owner=owner,
    repo_name=repo_name,
    issue_number=int(issue_number),
    ...
)

Proposed Test Case

1. Verify `make lint-all` passes after the fix (ty check hook succeeds)
2. Verify that passing None for any required parameter raises a clear ValueError
3. Verify that valid string values continue to work as before

Reproduction

1. Check out main
2. Run make lint-all
3. Observe ty check fails with 4 invalid-argument-type diagnostics

[rh-hemartin]

I totally forgot that the experiments is now a submodule, does this belong here or in the experiments repository? I think the latter.