From ce3f0c15fb790f3db2b6b77c104941a8b0df834d Mon Sep 17 00:00:00 2001 From: Sven Friese Date: Wed, 22 Jan 2025 09:17:08 +0100 Subject: [PATCH 1/2] Check for correct tag for metadata in gpx mapping --- src/Adapter/GPX.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Adapter/GPX.php b/src/Adapter/GPX.php index 1ac5a2d3..2d68119d 100644 --- a/src/Adapter/GPX.php +++ b/src/Adapter/GPX.php @@ -457,7 +457,7 @@ private function linestringToGPX($geom) public function collectionToGPX(Collection $geometry): string { $metadata = self::processGeometryData($geometry, $this->gpxTypes->get('metadataType')); - $metadata = empty($metadata) || !in_array('metadataType', $this->gpxTypes->get('gpxType')) + $metadata = empty($metadata) || !in_array('metadata', $this->gpxTypes->get('gpxType')) ? '' : "\n{$metadata}\n\n"; $wayPoints = $routes = $tracks = ""; From 9f87e95c53129402e5e332bca38457120c39d204 Mon Sep 17 00:00:00 2001 From: Sven Friese Date: Wed, 22 Jan 2025 09:20:27 +0100 Subject: [PATCH 2/2] Typo: Set correct default for allowed trkpt type elements --- src/Adapter/GpxTypes.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Adapter/GpxTypes.php b/src/Adapter/GpxTypes.php index 9edf0fe6..1c0741f1 100644 --- a/src/Adapter/GpxTypes.php +++ b/src/Adapter/GpxTypes.php @@ -124,7 +124,7 @@ public function __construct(?array $allowedElements = null) $this->allowedTrkTypeElements = self::$trkTypeElements; $this->allowedRteTypeElements = self::$rteTypeElements; $this->allowedWptTypeElements = self::$wptTypeElements; - $this->allowedTrkptTypeElements = self::$trkTypeElements; + $this->allowedTrkptTypeElements = self::$trkptTypeElements; $this->allowedRteptTypeElements = self::$rteptTypeElements; $this->allowedMetadataTypeElements = self::$metadataTypeElements;