chore: improve some test assertions

Author: ryanatkn

src/test/package_helpers.test.ts

@@ -1,4 +1,4 @@
-import {test, expect, describe} from 'vitest';
+import {test, assert, describe} from 'vitest';
 
 import {
 	url_github_file,
@@ -13,211 +13,227 @@ import {
 
 describe('url_github_file', () => {
 	test('builds basic file URL', () => {
-		expect(url_github_file('https://github.com/foo/bar', 'src/index.ts')).toBe(
+		assert.equal(
+			url_github_file('https://github.com/foo/bar', 'src/index.ts'),
 			'https://github.com/foo/bar/blob/main/src/index.ts',
 		);
 	});
 
 	test('strips leading ./ from file path', () => {
-		expect(url_github_file('https://github.com/foo/bar', './src/index.ts')).toBe(
+		assert.equal(
+			url_github_file('https://github.com/foo/bar', './src/index.ts'),
 			'https://github.com/foo/bar/blob/main/src/index.ts',
 		);
 	});
 
 	test('includes line number when provided', () => {
-		expect(url_github_file('https://github.com/foo/bar', 'src/index.ts', 42)).toBe(
+		assert.equal(
+			url_github_file('https://github.com/foo/bar', 'src/index.ts', 42),
 			'https://github.com/foo/bar/blob/main/src/index.ts#L42',
 		);
 	});
 
 	test('handles nested paths', () => {
-		expect(url_github_file('https://github.com/foo/bar', 'src/lib/utils/helpers.ts')).toBe(
+		assert.equal(
+			url_github_file('https://github.com/foo/bar', 'src/lib/utils/helpers.ts'),
 			'https://github.com/foo/bar/blob/main/src/lib/utils/helpers.ts',
 		);
 	});
 
 	test('handles root-level files', () => {
-		expect(url_github_file('https://github.com/foo/bar', 'README.md')).toBe(
+		assert.equal(
+			url_github_file('https://github.com/foo/bar', 'README.md'),
 			'https://github.com/foo/bar/blob/main/README.md',
 		);
 	});
 });
 
 describe('url_github_org', () => {
 	test('extracts org URL from repo URL', () => {
-		expect(url_github_org('https://github.com/fuzdev/fuz_ui', 'fuz_ui')).toBe(
+		assert.equal(
+			url_github_org('https://github.com/fuzdev/fuz_ui', 'fuz_ui'),
 			'https://github.com/fuzdev',
 		);
 	});
 
 	test('returns null when repo name does not match', () => {
-		expect(url_github_org('https://github.com/fuzdev/fuz_ui', 'other_repo')).toBe(null);
+		assert.equal(url_github_org('https://github.com/fuzdev/fuz_ui', 'other_repo'), null);
 	});
 
 	test('returns null for partial match', () => {
-		expect(url_github_org('https://github.com/fuzdev/fuz_ui_extra', 'fuz_ui')).toBe(null);
+		assert.equal(url_github_org('https://github.com/fuzdev/fuz_ui_extra', 'fuz_ui'), null);
 	});
 
 	test('handles single-word org names', () => {
-		expect(url_github_org('https://github.com/org/repo', 'repo')).toBe('https://github.com/org');
+		assert.equal(url_github_org('https://github.com/org/repo', 'repo'), 'https://github.com/org');
 	});
 });
 
 describe('repo_url_github_owner', () => {
 	test('extracts owner from GitHub URL', () => {
-		expect(repo_url_github_owner('https://github.com/fuzdev/fuz_ui')).toBe('fuzdev');
+		assert.equal(repo_url_github_owner('https://github.com/fuzdev/fuz_ui'), 'fuzdev');
 	});
 
 	test('returns null for non-GitHub URL', () => {
-		expect(repo_url_github_owner('https://gitlab.com/foo/bar')).toBe(null);
+		assert.equal(repo_url_github_owner('https://gitlab.com/foo/bar'), null);
 	});
 
 	test('returns null for malformed GitHub URL', () => {
-		expect(repo_url_github_owner('https://github.com/')).toBe(null);
+		assert.equal(repo_url_github_owner('https://github.com/'), null);
 	});
 
 	test('handles URLs with trailing content', () => {
-		expect(repo_url_github_owner('https://github.com/owner/repo/tree/main')).toBe('owner');
+		assert.equal(repo_url_github_owner('https://github.com/owner/repo/tree/main'), 'owner');
 	});
 
 	test('returns null for http (non-https) URL', () => {
-		expect(repo_url_github_owner('http://github.com/foo/bar')).toBe(null);
+		assert.equal(repo_url_github_owner('http://github.com/foo/bar'), null);
 	});
 });
 
 describe('url_npm_package', () => {
 	test('builds URL for unscoped package', () => {
-		expect(url_npm_package('lodash')).toBe('https://www.npmjs.com/package/lodash');
+		assert.equal(url_npm_package('lodash'), 'https://www.npmjs.com/package/lodash');
 	});
 
 	test('builds URL for scoped package', () => {
-		expect(url_npm_package('@fuzdev/fuz_ui')).toBe('https://www.npmjs.com/package/@fuzdev/fuz_ui');
+		assert.equal(url_npm_package('@fuzdev/fuz_ui'), 'https://www.npmjs.com/package/@fuzdev/fuz_ui');
 	});
 });
 
 describe('package_is_published', () => {
 	test('returns true for published package', () => {
-		expect(
+		assert.equal(
 			package_is_published({
 				name: 'my-package',
 				version: '1.0.0',
 				exports: {'.': './index.js'},
 			}),
-		).toBe(true);
+			true,
+		);
 	});
 
 	test('returns false for private package', () => {
-		expect(
+		assert.equal(
 			package_is_published({
 				name: 'my-package',
 				version: '1.0.0',
 				private: true,
 				exports: {'.': './index.js'},
 			}),
-		).toBe(false);
+			false,
+		);
 	});
 
 	test('returns false for package without exports', () => {
-		expect(
+		assert.equal(
 			package_is_published({
 				name: 'my-package',
 				version: '1.0.0',
 			}),
-		).toBe(false);
+			false,
+		);
 	});
 
 	test('returns false for initial version 0.0.1', () => {
-		expect(
+		assert.equal(
 			package_is_published({
 				name: 'my-package',
 				version: '0.0.1',
 				exports: {'.': './index.js'},
 			}),
-		).toBe(false);
+			false,
+		);
 	});
 
 	test('returns true for version 0.0.2', () => {
-		expect(
+		assert.equal(
 			package_is_published({
 				name: 'my-package',
 				version: '0.0.2',
 				exports: {'.': './index.js'},
 			}),
-		).toBe(true);
+			true,
+		);
 	});
 });
 
 describe('repo_name_parse', () => {
 	test('returns name for unscoped package', () => {
-		expect(repo_name_parse('lodash')).toBe('lodash');
+		assert.equal(repo_name_parse('lodash'), 'lodash');
 	});
 
 	test('extracts name from scoped package', () => {
-		expect(repo_name_parse('@fuzdev/fuz_ui')).toBe('fuz_ui');
+		assert.equal(repo_name_parse('@fuzdev/fuz_ui'), 'fuz_ui');
 	});
 
 	test('throws for malformed scoped package', () => {
-		expect(() => repo_name_parse('@fuzdev')).toThrow('invalid scoped package name');
+		assert.throws(() => repo_name_parse('@fuzdev'), /invalid scoped package name/);
 	});
 
 	test('handles package names with hyphens', () => {
-		expect(repo_name_parse('@org/my-package-name')).toBe('my-package-name');
+		assert.equal(repo_name_parse('@org/my-package-name'), 'my-package-name');
 	});
 });
 
 describe('repo_url_parse', () => {
 	test('returns null for undefined', () => {
-		expect(repo_url_parse(undefined)).toBe(null);
+		assert.equal(repo_url_parse(undefined), null);
 	});
 
 	test('handles string URL directly', () => {
-		expect(repo_url_parse('https://github.com/foo/bar')).toBe('https://github.com/foo/bar');
+		assert.equal(repo_url_parse('https://github.com/foo/bar'), 'https://github.com/foo/bar');
 	});
 
 	test('extracts URL from object format', () => {
-		expect(repo_url_parse({type: 'git', url: 'https://github.com/foo/bar'})).toBe(
+		assert.equal(
+			repo_url_parse({type: 'git', url: 'https://github.com/foo/bar'}),
 			'https://github.com/foo/bar',
 		);
 	});
 
 	test('strips git+ prefix', () => {
-		expect(repo_url_parse('git+https://github.com/foo/bar')).toBe('https://github.com/foo/bar');
+		assert.equal(repo_url_parse('git+https://github.com/foo/bar'), 'https://github.com/foo/bar');
 	});
 
 	test('strips .git suffix', () => {
-		expect(repo_url_parse('https://github.com/foo/bar.git')).toBe('https://github.com/foo/bar');
+		assert.equal(repo_url_parse('https://github.com/foo/bar.git'), 'https://github.com/foo/bar');
 	});
 
 	test('strips both git+ prefix and .git suffix', () => {
-		expect(repo_url_parse({type: 'git', url: 'git+https://github.com/foo/bar.git'})).toBe(
+		assert.equal(
+			repo_url_parse({type: 'git', url: 'git+https://github.com/foo/bar.git'}),
 			'https://github.com/foo/bar',
 		);
 	});
 
 	test('strips trailing slash', () => {
-		expect(repo_url_parse('https://github.com/foo/bar/')).toBe('https://github.com/foo/bar');
+		assert.equal(repo_url_parse('https://github.com/foo/bar/'), 'https://github.com/foo/bar');
 	});
 
 	test('returns null for object without url', () => {
-		expect(repo_url_parse({type: 'git'} as any)).toBe(null);
+		assert.equal(repo_url_parse({type: 'git'} as any), null);
 	});
 });
 
 describe('url_well_known', () => {
 	test('builds .well-known URL', () => {
-		expect(url_well_known('https://fuz.dev', 'package.json')).toBe(
+		assert.equal(
+			url_well_known('https://fuz.dev', 'package.json'),
 			'https://fuz.dev/.well-known/package.json',
 		);
 	});
 
 	test('handles homepage with trailing slash', () => {
-		expect(url_well_known('https://fuz.dev/', 'package.json')).toBe(
+		assert.equal(
+			url_well_known('https://fuz.dev/', 'package.json'),
 			'https://fuz.dev/.well-known/package.json',
 		);
 	});
 
 	test('handles various filenames', () => {
-		expect(url_well_known('https://example.com', 'security.txt')).toBe(
+		assert.equal(
+			url_well_known('https://example.com', 'security.txt'),
 			'https://example.com/.well-known/security.txt',
 		);
 	});