Emit sourcemaps

[gaearon]

Currently sourcemaps are not emitted. This complicates debugging.

Sample implementation from imports-loader

[gaearon]

@sokra What would be a sane approach? Ideally I want to hide the fact I'm using two loaders here (index and replaceCreateClass). Should they both handle source maps somehow?

[sokra]

Only replaceCreateClass needs a SourceMap. Just use the SourceNode class from the source-map library instead of string concat. You may want to import the map that is passed from the previous loader (jsx-loader) with SourceNode.fromStringWithSourceMap. You receive it as second argument to the loader. Instead of return you need to call this.callback(null, code, map).

Currently the jsx-loader doesn't emit SourceMaps, but it should! 😄 @petehunt

[gaearon]

Thanks! Will look into it.

[petehunt]

petehunt/jsx-loader#16

[KyleAMathews]

Anything I can do to help sourcemaps happen?

[sokra]

You can fix the PR in the jsx-loader

[SanderSpies]

jsx-loader supports sourcemaps now - so we only need to get react-hot-loader to play nicely with it.

[gaearon]

Oh well. I'll update the PR then this weekend!

[SanderSpies]

Great 👍

[gaearon]

Source maps are in 0.5.0, thanks to @jRiest.