Update ci.yml

Author: gamblecodezcom

.github/workflows/ci.yml

@@ -1,65 +1,83 @@
 name: CI
 
 # ──────────────────────────────────────────────────────────────────────────────
-# Runs on every pull request and on pushes to non-main branches.
-# Purpose: Fast quality gate (syntax + tests + audit).
-# The full deploy pipeline lives in deploy.yml (push to main only).
+# PURPOSE:
+#   - Runs on all PRs and pushes to non-main branches.
+#   - Fast, deterministic quality gate: syntax → tests → audit → smoke.
+#   - Never deploys. Never touches the VPS. Never writes artifacts.
+#   - Full deploy pipeline lives in deploy.yml (main branch only).
 # ──────────────────────────────────────────────────────────────────────────────
 on:
   pull_request:
   push:
     branches-ignore: [main]
 
-# Minimal read-only permissions — no write access needed for CI validation
 permissions:
   contents: read
 
 jobs:
+
+  # ────────────────────────────────────────────────────────────────────────────
+  # Job 1: Validate (syntax, tests, audit)
+  # ────────────────────────────────────────────────────────────────────────────
   validate:
     name: Validate
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v4
+      - name: Checkout
+        uses: actions/checkout@v4
 
-      - uses: actions/setup-node@v4
+      - name: Setup Node.js 20
+        uses: actions/setup-node@v4
         with:
           node-version: '20'
           cache: 'npm'
 
       - name: Install dependencies
         run: npm ci
 
+      # Syntax / type / lint checks
       - name: Syntax check
         run: npm run check
 
+      # Unit tests (fail-fast)
       - name: Run tests
         run: npm test
 
+      # Security audit (warn only)
       - name: Security audit (high+critical only)
         run: npm audit --audit-level=high
-        continue-on-error: true   # Warn but don't block PR for advisories
+        continue-on-error: true
 
-  # Lightweight integration check (does the bot start without crashing?)
+  # ────────────────────────────────────────────────────────────────────────────
+  # Job 2: Smoke test (lightweight integration)
+  # Ensures the bot can be required without crashing.
+  # Does NOT start the bot (no BOT_TOKEN in CI).
+  # ────────────────────────────────────────────────────────────────────────────
   smoke:
-    name: Smoke
+    name: Smoke Test
     runs-on: ubuntu-latest
     needs: validate
 
     steps:
-      - uses: actions/checkout@v4
+      - name: Checkout
+        uses: actions/checkout@v4
 
-      - uses: actions/setup-node@v4
+      - name: Setup Node.js 20
+        uses: actions/setup-node@v4
         with:
           node-version: '20'
           cache: 'npm'
 
       - name: Install dependencies
         run: npm ci
 
-      - name: Check entrypoint can be required without errors
+      - name: Validate entrypoint loads cleanly
         run: |
-          # We can't fully start the bot (no BOT_TOKEN), but we can check
-          # that the file is syntactically and structurally valid.
+          # node --check ensures syntax correctness
           node --check index.js
           echo "✅ index.js passes node --check"
+
+          # Try requiring the bot without executing Telegram logic
+          node -e "require('./index.js'); console.log('✅ index.js can be required without crashing')"