From ceeb1a4caf2bfe2ee4171f3f8c6f7d4cc36759ee Mon Sep 17 00:00:00 2001 From: Max Horn Date: Thu, 4 Sep 2025 17:49:53 +0200 Subject: [PATCH 1/3] Require setup-gap@v3 to simplify some code --- .github/workflows/CI.yml | 17 ++++++++--------- README.md | 10 +++++++--- action.yml | 12 ------------ 3 files changed, 15 insertions(+), 24 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index d1b4296..2dae276 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -17,13 +17,13 @@ jobs: strategy: fail-fast: false matrix: - gap-branch: + gap-version: - master - - stable-4.14 - - stable-4.13 - - stable-4.12 - - stable-4.11 - - stable-4.10 + - 4.14 + - 4.13 + - 4.12 + - 4.11 + - 4.10 steps: # the order of the checkout actions is important because all contents of @@ -36,10 +36,9 @@ jobs: uses: actions/checkout@v5 with: path: this-action/ - - uses: gap-actions/setup-gap@v2 + - uses: gap-actions/setup-gap@v3 with: - GAPBRANCH: ${{ matrix.gap-branch }} - GAP_PKGS_TO_BUILD: '' + gap-version: ${{ matrix.gap-version }} - uses: gap-actions/build-pkg@v1 - uses: gap-actions/run-pkg-tests@v3 - uses: ./this-action/ diff --git a/README.md b/README.md index 406efda..a51d48d 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -# process-coverage V2 +# process-coverage This GitHub action prepares coverage data for GAP packages for upload to [Codecov](https://www.codecov.io/). @@ -13,6 +13,10 @@ package. By default it processes the coverage data gathered during the action [gap-actions/run-test-for-packages](https://github.com/gap-actions/run-pkg-tests). +### What's new in v3 + +This action now requires `gap-actions/setup-gap@v3`. + ### Example The following is a minimal example to run this action. @@ -32,10 +36,10 @@ jobs: steps: - uses: actions/checkout@v5 - - uses: gap-actions/setup-gap@v2 + - uses: gap-actions/setup-gap@v3 - uses: gap-actions/build-pkg@v1 - uses: gap-actions/run-pkg-tests@v2 - - uses: gap-actions/process-coverage@v2 + - uses: gap-actions/process-coverage@v3 - uses: codecov/codecov-action@v5 ``` diff --git a/action.yml b/action.yml index 6dece31..fe87827 100644 --- a/action.yml +++ b/action.yml @@ -7,9 +7,6 @@ runs: - name: "Build io and profiling packages if necessary" shell: bash run: | - set -ex - GAPROOT=${GAPROOT-$HOME/gap} - # the following somewhat awkward `cd` invocation ensures # compatibility with both GAP <= 4.11 (with package dir names like # `pkg/io-1.2.3`) and GAP >= 4.12 (where it is `pkg/io`) @@ -32,15 +29,6 @@ runs: - name: "Process coverage data" shell: bash run: | - set -ex - GAPROOT=${GAPROOT-$HOME/gap} - - mkdir -p /tmp/gaproot/pkg/ - ln -f -s $PWD /tmp/gaproot/pkg/ - - # start GAP with custom GAP root, to ensure correct package version is loaded - GAP="$GAPROOT/gap -l /tmp/gaproot; --quitonbreak -q" - # generate library coverage reports $GAP -q < true then From 9e4cc6614e8b70cfc5fc02338dec84c4feae3a41 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Thu, 4 Sep 2025 17:55:06 +0200 Subject: [PATCH 2/3] oops --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 2dae276..8b3a7ac 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -12,7 +12,7 @@ env: jobs: test: - name: ${{ matrix.gap-branch }} + name: ${{ matrix.gap-version }} runs-on: ubuntu-latest strategy: fail-fast: false From 3e0299fdf7ce3a9f649d096f64507fdc9e44cff3 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Thu, 4 Sep 2025 17:57:57 +0200 Subject: [PATCH 3/3] quotes --- .github/workflows/CI.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 8b3a7ac..4f0dbfb 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -19,11 +19,11 @@ jobs: matrix: gap-version: - master - - 4.14 - - 4.13 - - 4.12 - - 4.11 - - 4.10 + - '4.14' + - '4.13' + - '4.12' + - '4.11' + - '4.10' steps: # the order of the checkout actions is important because all contents of