Skip to content

Correctly wait for upto MachineCreationTimeout in waitForServerStatus #391

@elankath

Description

@elankath

In Executor.CreateMachine invoked by Driver.CreateMachine we have HARD-CODED the provisioning time for the openstack Server object when waiting for it to become active to 1200 seconds. See

activeServer, err = ex.waitForServerStatus(ctx,

var activeServer *servers.Server  
activeServer, err = ex.waitForServerStatus(ctx,  
    server.ID,  
    []string{client.ServerStatusBuild},  
    []string{client.ServerStatusActive}, 1200)  
if err != nil {  
    return nil, deleteOnFail(fmt.Errorf("error waiting for server [ID=%q] to reach target status: %w", server.ID, err))  
}

This is incorrect. We should use machine.Spec.MachineConfiguration.MachineCreationTimeout. In future effective MachineCreationTimeout's will be adjusted by the gardener/dependency-watchdog and should be honored by MCM and providers.

Metadata

Metadata

Assignees

Labels

Type

No fields configured for Bug.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions