Skip to content

Commit b8ff733

Browse files
committed
feat: Show basic information messages
Agent now prints "starting" and "appmap saved" messages on stdout unless appmap.silent is set.
1 parent addd903 commit b8ff733

4 files changed

Lines changed: 21 additions & 1 deletion

File tree

agent/src/main/java/com/appland/appmap/Agent.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import java.util.jar.JarEntry;
1818
import java.util.jar.JarFile;
1919

20+
import com.appland.appmap.util.Logger;
2021
import org.apache.commons.io.FilenameUtils;
2122
import org.apache.commons.io.IOUtils;
2223
import org.tinylog.TaggedLogger;
@@ -66,8 +67,10 @@ public static void premain(String agentArgs, Instrumentation inst) {
6667
"To disable the automatic creation of this log file, set the system property {} to 'true'",
6768
Properties.DISABLE_LOG_FILE_KEY);
6869
}
70+
String implementationVersion = Agent.class.getPackage().getImplementationVersion();
71+
Logger.printUserMessage("AppMap agent version %s starting\n", implementationVersion);
6972
logger.info("Agent version {}, current time mills: {}",
70-
Agent.class.getPackage().getImplementationVersion(), start);
73+
implementationVersion, start);
7174
logger.info("config: {}", AppMapConfig.get());
7275
logger.info("System properties: {}", System.getProperties());
7376
logger.debug(new Exception(), "whereAmI");

agent/src/main/java/com/appland/appmap/config/Properties.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
public class Properties {
1010
public static final String APPMAP_OUTPUT_DIRECTORY_KEY = "appmap.output.directory";
1111
public static final String DISABLE_LOG_FILE_KEY = "appmap.disableLogFile";
12+
13+
public static final Boolean Silent = resolveProperty("appmap.silent", false);
14+
1215
public static final Boolean DisableLogFile = resolveProperty(DISABLE_LOG_FILE_KEY, true);
1316
public static final Boolean Debug = resolveProperty("appmap.debug", false);
1417
public static final Boolean DebugHooks = Debug || (System.getProperty("appmap.debug.hooks") != null);

agent/src/main/java/com/appland/appmap/record/Recording.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import java.util.List;
1919
import java.util.function.Function;
2020

21+
import com.appland.appmap.util.Logger;
2122
import org.tinylog.TaggedLogger;
2223

2324
import com.appland.appmap.config.AppMapConfig;
@@ -94,6 +95,7 @@ public Path moveTo(Path targetPath) {
9495
throw new RuntimeException(String.join(", ", errors));
9596
}
9697

98+
Logger.printUserMessage("AppMap recording saved to %s\n", targetPath.toAbsolutePath());
9799
return targetPath;
98100
}
99101

agent/src/main/java/com/appland/appmap/util/Logger.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.appland.appmap.util;
22

33
import com.appland.appmap.config.AppMapConfig;
4+
import com.appland.appmap.config.Properties;
45

56
public class Logger {
67
private static final org.tinylog.TaggedLogger logger = AppMapConfig.getLogger(null);
@@ -25,4 +26,15 @@ public static void error(Throwable t) {
2526
println(t);
2627
}
2728

29+
/**
30+
* Print a message on stderr unless the silent flag is set.
31+
* @param format
32+
* @param args
33+
*/
34+
public static void printUserMessage(String format, Object... args) {
35+
if (!Properties.Silent) {
36+
System.err.printf(format, args);
37+
}
38+
}
39+
2840
}

0 commit comments

Comments
 (0)