Commit 20dafa5
committed
fix(compose): finish evicted root spans instead of leaving them open
isIdle spans only auto-finish when the whole transaction finishes, so
evicting a cached root span from RootSpans without finishing it left
it open on the transaction. If the same scopes was used again later, a
fresh root span was created alongside the still-open, now-untracked
original, showing up as a duplicate root span once the transaction
finished.
release now finishes the evicted composition/rendering spans before
dropping them from the cache.1 parent 863894f commit 20dafa5
2 files changed
Lines changed: 29 additions & 2 deletions
File tree
- sentry-compose/src
- androidMain/kotlin/io/sentry/compose
- androidUnitTest/kotlin/io/sentry/compose
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
95 | | - | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
96 | 100 | | |
97 | 101 | | |
98 | 102 | | |
| |||
Lines changed: 23 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| |||
147 | 148 | | |
148 | 149 | | |
149 | 150 | | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
150 | 173 | | |
0 commit comments