Rename childStartTimestampOrNull() -> computeNanoStartTimestampForChild()

Author: 0xadam-brown

sentry-android-sqlite/src/main/java/io/sentry/sqlite/SQLiteSpanInstrumentation.kt

@@ -38,7 +38,7 @@ internal class SQLiteSpanInstrumentation(
    */
   fun startTimestamp(): Long =
     // Try to retain nanosecond precision + avoid SentryDate allocation...
-    scopes.span?.childStartTimestampOrNull()
+    scopes.span?.computeNanoStartTimestampForChild()
       // ...otherwise fall back to millisecond precision + allocate.
       ?: scopes.options.dateProvider.now().nanoTimestamp()
 
@@ -111,7 +111,7 @@ internal class SQLiteSpanInstrumentation(
  * END TRANSACTION                     ├███┤   0.33 ms
  * ```
  */
-internal fun ISpan.childStartTimestampOrNull(): Long? {
+internal fun ISpan.computeNanoStartTimestampForChild(): Long? {
   if (startDate !is SentryNanotimeDate) {
     return null
   }

…/sqlite/ChildStartTimestampOrNullTest.kt …ComputeNanoStartTimestampForChildTest.ktsentry-android-sqlite/src/test/java/io/sentry/sqlite/ChildStartTimestampOrNullTest.kt renamed to sentry-android-sqlite/src/test/java/io/sentry/sqlite/ComputeNanoStartTimestampForChildTest.kt sentry-android-sqlite/src/test/java/io/sentry/sqlite/ChildStartTimestampOrNullTest.kt renamed to sentry-android-sqlite/src/test/java/io/sentry/sqlite/ComputeNanoStartTimestampForChildTest.kt

@@ -12,7 +12,7 @@ import kotlin.test.assertTrue
 import org.mockito.kotlin.mock
 import org.mockito.kotlin.whenever
 
-class ChildStartTimestampOrNullTest {
+class ComputeNanoStartTimestampForChildTest {
 
   @Test
   fun `returns parent wall clock plus elapsed monotonic time since parent started`() {
@@ -21,7 +21,7 @@ class ChildStartTimestampOrNullTest {
     val parentMonotonicNanos = System.nanoTime() - elapsedNanos
     val span = spanWithNanotimeStart(wallClockMillis, parentMonotonicNanos)
 
-    val timestamp = span.childStartTimestampOrNull()!!
+    val timestamp = span.computeNanoStartTimestampForChild()!!
 
     val elapsedSinceParentStart = timestamp - DateUtils.millisToNanos(wallClockMillis)
     assertTrue(elapsedSinceParentStart >= elapsedNanos)
@@ -43,8 +43,8 @@ class ChildStartTimestampOrNullTest {
       "Raw parent timestamps share the same ms-quantized value",
     )
 
-    val earlier = earlierSpan.childStartTimestampOrNull()!!
-    val later = laterSpan.childStartTimestampOrNull()!!
+    val earlier = earlierSpan.computeNanoStartTimestampForChild()!!
+    val later = laterSpan.computeNanoStartTimestampForChild()!!
 
     assertTrue(earlier > wallClockNanos)
     assertTrue(later > wallClockNanos)
@@ -59,7 +59,7 @@ class ChildStartTimestampOrNullTest {
     val span = spanWithNanotimeStart(wallClockMillis, parentMonotonicNanos)
 
     val elapsedSinceParentStart =
-      span.childStartTimestampOrNull()!! - DateUtils.millisToNanos(wallClockMillis)
+      span.computeNanoStartTimestampForChild()!! - DateUtils.millisToNanos(wallClockMillis)
     assertTrue(elapsedSinceParentStart >= 0L)
     assertTrue(elapsedSinceParentStart < TEST_SLACK_NANOS)
   }
@@ -72,7 +72,7 @@ class ChildStartTimestampOrNullTest {
     val span = spanWithNanotimeStart(wallClockMillis, parentMonotonicNanos)
 
     val elapsedSinceParentStart =
-      span.childStartTimestampOrNull()!! - DateUtils.millisToNanos(wallClockMillis)
+      span.computeNanoStartTimestampForChild()!! - DateUtils.millisToNanos(wallClockMillis)
     assertTrue(elapsedSinceParentStart >= elapsedNanos)
     assertTrue(elapsedSinceParentStart < elapsedNanos + TEST_SLACK_NANOS)
   }
@@ -82,7 +82,7 @@ class ChildStartTimestampOrNullTest {
     val span = mock<ISpan>()
     whenever(span.startDate).thenReturn(SentryLongDate(DateUtils.millisToNanos(1_000_000L)))
 
-    assertNull(span.childStartTimestampOrNull())
+    assertNull(span.computeNanoStartTimestampForChild())
   }
 
   private fun spanWithNanotimeStart(wallClockMillis: Long, parentMonotonicNanos: Long): ISpan {