Skip to content

Commit 410a72f

Browse files
committed
feat(v11): Drop TypeScript 3.8 support
Minimum supported TypeScript is now 5.0, so remove the downlevel-dts type path and the TS 3.8 test surface: - drop each package's typesVersions "<5.0" mapping and the build:types:downlevel step (build:types is just tsc now) - remove downlevel-dts and the ts3.8 shim scripts/type-shims - bump the node integration-test TS matrix to 5.0 (use-ts-5_0) - drop the TS 3.8 e2e variants and the generic-ts3.8 app - use the built-in Awaited type instead of the vendored shim
1 parent 8c6358a commit 410a72f

68 files changed

Lines changed: 81 additions & 774 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/build.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ jobs:
801801
include:
802802
# Only check typescript for latest version (to streamline CI)
803803
- node: 24
804-
typescript: '3.8'
804+
typescript: '5.0'
805805
# No need to test orchestrion for v18
806806
- node: 20
807807
use_orchestrion: 'true'
@@ -826,8 +826,8 @@ jobs:
826826
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
827827

828828
- name: Overwrite typescript version
829-
if: matrix.typescript == '3.8'
830-
run: node ./scripts/use-ts-3_8.js
829+
if: matrix.typescript == '5.0'
830+
run: node ./scripts/use-ts-5_0.js
831831
working-directory: dev-packages/node-integration-tests
832832

833833
- name: Run integration tests
@@ -875,7 +875,7 @@ jobs:
875875
include:
876876
# Only check typescript for latest version (to streamline CI)
877877
- node: 24
878-
typescript: '3.8'
878+
typescript: '5.0'
879879
steps:
880880
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
881881
uses: actions/checkout@v7
@@ -891,8 +891,8 @@ jobs:
891891
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
892892

893893
- name: Overwrite typescript version
894-
if: matrix.typescript == '3.8'
895-
run: node ./scripts/use-ts-3_8.js
894+
if: matrix.typescript == '5.0'
895+
run: node ./scripts/use-ts-5_0.js
896896
working-directory: dev-packages/node-core-integration-tests
897897

898898
- name: Run integration tests

dev-packages/e2e-tests/test-applications/create-react-app/package.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
"eject": "react-scripts eject",
2020
"clean": "npx rimraf node_modules pnpm-lock.yaml",
2121
"test:build": "pnpm install && pnpm build",
22-
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
2322
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
2423
"test:assert": "pnpm -v"
2524
},
@@ -43,13 +42,5 @@
4342
},
4443
"volta": {
4544
"extends": "../../package.json"
46-
},
47-
"sentryTest": {
48-
"variants": [
49-
{
50-
"build-command": "pnpm test:build-ts3.8",
51-
"label": "create-react-app (TS 3.8)"
52-
}
53-
]
5445
}
5546
}

dev-packages/e2e-tests/test-applications/generic-ts3.8/index.ts

Lines changed: 0 additions & 5 deletions
This file was deleted.

dev-packages/e2e-tests/test-applications/generic-ts3.8/package.json

Lines changed: 0 additions & 34 deletions
This file was deleted.

dev-packages/e2e-tests/test-applications/generic-ts3.8/tsconfig.json

Lines changed: 0 additions & 11 deletions
This file was deleted.

dev-packages/e2e-tests/test-applications/react-17/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
"test": "playwright test",
2020
"clean": "npx rimraf node_modules pnpm-lock.yaml",
2121
"test:build": "pnpm install && pnpm build",
22-
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
2322
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
2423
"test:assert": "pnpm test"
2524
},

dev-packages/e2e-tests/test-applications/react-router-6-descendant-routes/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
"test": "playwright test",
2222
"clean": "npx rimraf node_modules pnpm-lock.yaml",
2323
"test:build": "pnpm install && npx playwright install && pnpm build",
24-
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
2524
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
2625
"test:assert": "pnpm test"
2726
},

dev-packages/e2e-tests/test-applications/react-router-6-use-routes/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
"test": "playwright test",
1919
"clean": "npx rimraf node_modules pnpm-lock.yaml",
2020
"test:build": "pnpm install && pnpm build",
21-
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
2221
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
2322
"test:assert": "pnpm test"
2423
},

dev-packages/e2e-tests/test-applications/react-router-6/package.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
"test": "playwright test",
2222
"clean": "npx rimraf node_modules pnpm-lock.yaml",
2323
"test:build": "pnpm install && pnpm build",
24-
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
2524
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
2625
"test:assert": "pnpm test"
2726
},
@@ -51,13 +50,5 @@
5150
},
5251
"volta": {
5352
"extends": "../../package.json"
54-
},
55-
"sentryTest": {
56-
"variants": [
57-
{
58-
"build-command": "pnpm test:build-ts3.8",
59-
"label": "react-router-6 (TS 3.8)"
60-
}
61-
]
6253
}
6354
}

dev-packages/e2e-tests/test-applications/react-router-7-cross-usage/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
"test": "playwright test",
2020
"clean": "npx rimraf node_modules pnpm-lock.yaml",
2121
"test:build": "pnpm install && npx playwright install && pnpm build",
22-
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
2322
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
2423
"test:assert": "pnpm test"
2524
},

0 commit comments

Comments
 (0)