Skip to content

Commit 96e36bc

Browse files
authored
fix(repo): fix tsconfig diagnostics surfaced by tsgolint 7 (#22560)
Fixes the per-package tsconfig problems tsgolint 7 surfaces once program diagnostics are no longer suppressed. Those weren't caught because the build process doesn't use TS 7 for these projects. This allows them to be linted with unsuppressed tslint in a later PR.
1 parent 7f55ee8 commit 96e36bc

3 files changed

Lines changed: 14 additions & 10 deletions

File tree

packages/effect/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
{
22
"extends": "../../tsconfig.json",
33
"compilerOptions": {
4-
"outDir": "build"
4+
"outDir": "build",
5+
"rootDir": "./src"
56
},
67
"include": ["src/**/*"]
78
}

packages/ember/tsconfig.json

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,15 @@
1010
"strictPropertyInitialization": true,
1111
"noEmitOnError": false,
1212
"noEmit": true,
13-
"baseUrl": ".",
1413
"experimentalDecorators": true,
1514
"paths": {
16-
"dummy/tests/*": ["tests/*"],
17-
"dummy/*": ["tests/dummy/app/*", "app/*"],
18-
"@sentry/ember": ["addon"],
19-
"@sentry/ember/*": ["addon/*"],
20-
"@sentry/ember/test-support": ["addon-test-support"],
21-
"@sentry/ember/test-support/*": ["addon-test-support/*"],
22-
"*": ["types/*"]
15+
"dummy/tests/*": ["./tests/*"],
16+
"dummy/*": ["./tests/dummy/app/*", "./app/*"],
17+
"@sentry/ember": ["./addon"],
18+
"@sentry/ember/*": ["./addon/*"],
19+
"@sentry/ember/test-support": ["./addon-test-support"],
20+
"@sentry/ember/test-support/*": ["./addon-test-support/*"],
21+
"*": ["./types/*"]
2322
}
2423
},
2524
"include": ["app/**/*", "addon/**/*", "tests/**/*", "types/**/*", "test-support/**/*", "addon-test-support/**/*"]

packages/profiling-node/tsconfig.test.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,11 @@
55

66
"compilerOptions": {
77
// should include all types from `./tsconfig.json` plus types for all test frameworks used
8-
"types": ["node"]
8+
"types": ["node"],
9+
10+
// The base config sets `rootDir` to `./src`, but the test program also pulls in `test/**/*` and
11+
// `vite.config.ts`, so widen it to the package root to keep them under `rootDir`.
12+
"rootDir": "."
913

1014
// other package-specific, test-specific options
1115
}

0 commit comments

Comments
 (0)