chore(oxlint): tune and clear the remaining warnings from the bump

The oxlint 1.75 bump surfaced ~5.9k warnings. This clears them to zero without
churning the codebase:

- Vitest: keep the plugin (and its ~60 other rules) but disable the correctness
  rules the bump newly fired across the existing suite (no-standalone-expect,
  require-mock-type-parameters, no-conditional-expect, expect-expect, valid-title,
  valid-expect, require-to-throw-message, no-disabled-tests, valid-describe-callback).
- Disable rules that over-trigger / false-positive here: no-useless-default-assignment,
  no-useless-fallback-in-spread, no-thenable (we implement thenables), no-new-array
  (used with immediate .fill()), prefer-string-starts-ends-with.
- Keep no-empty-file on (catches accidental empties) but exempt the two intentional
  comment-only files, and silence test-file occurrences of the general rules.
- Fix the few worth fixing: drop redundant `void` operators in the graphql/firebase
  channel callbacks, type the bun test-runner fetch init as RequestInit, and suppress
  the two no-unreachable false positives in rollup dual-build helpers.

Note: vitest/valid-expect flagged 10 pre-existing broken tests (chai-style `.to.`
modifiers); left for a separate fix.

Author: logaretm

.oxlintrc.base.json

@@ -31,6 +31,24 @@
     "no-constant-binary-expression": "off",
     "vitest/hoisted-apis-on-top": "off",
     "vitest/no-conditional-tests": "off",
+    // Vitest correctness rules newly surfaced by the oxlint 1.75 bump. We keep the vitest plugin
+    // (and its many other rules), but disable the ones now firing across the existing test suite.
+    "vitest/no-standalone-expect": "off",
+    "vitest/require-mock-type-parameters": "off",
+    "vitest/no-conditional-expect": "off",
+    "vitest/expect-expect": "off",
+    "vitest/require-to-throw-message": "off",
+    "vitest/valid-title": "off",
+    "vitest/valid-expect": "off",
+    "vitest/no-disabled-tests": "off",
+    "vitest/valid-describe-callback": "off",
+    // Not trusted / false positives for this codebase: the default-assignment and spread-fallback
+    // rules over-trigger, and we intentionally implement thenables (SyncPromise etc.).
+    "typescript/no-useless-default-assignment": "off",
+    "unicorn/no-useless-fallback-in-spread": "off",
+    "unicorn/no-thenable": "off",
+    "unicorn/prefer-string-starts-ends-with": "off",
+    "unicorn/no-new-array": "off",
     "no-unsafe-optional-chaining": "off",
     "no-eval": "off",
     "no-import-assign": "off",
@@ -101,7 +119,12 @@
         "typescript/require-array-sort-compare": "off",
         "typescript/no-base-to-string": "off",
         "typescript/await-thenable": "off",
-        "typescript/no-deprecated": "off"
+        "typescript/no-deprecated": "off",
+        "no-unreachable": "off",
+        "unicorn/no-empty-file": "off",
+        "unicorn/no-single-promise-in-promise-methods": "off",
+        "unicorn/no-invalid-fetch-options": "off",
+        "unicorn/no-await-in-promise-methods": "off"
       }
     },
     {
@@ -194,6 +217,14 @@
       "rules": {
         "no-restricted-globals": ["error", "window", "document", "location", "navigator"]
       }
+    },
+    {
+      // Intentionally comment-only: a grep marker for the release-injection file, and a
+      // resolvable-but-empty module used to mock `$app/stores` in sveltekit tests.
+      "files": ["**/sentry-release-injection-file.js", "**/.empty.js"],
+      "rules": {
+        "unicorn/no-empty-file": "off"
+      }
     }
   ]
 }

dev-packages/bun-integration-tests/runner.ts

@@ -240,7 +240,8 @@ export function createRunner(...paths: string[]) {
           if (process.env.DEBUG) log('making request', method, url, headers, body);
 
           try {
-            const res = await fetch(url, { headers, method, body });
+            const init: RequestInit = { headers, method, body };
+            const res = await fetch(url, init);
 
             if (!res.ok) {
               if (!expectError) {

packages/google-cloud-serverless/src/sdk.ts

@@ -14,6 +14,7 @@ function getCjsOnlyIntegrations(): Integration[] {
   ];
   /*! rollup-include-cjs-only-end */
   /*! rollup-include-esm-only */
+  // oxlint-disable-next-line no-unreachable -- reachable only in the ESM build; rollup strips the CJS return above
   return [];
   /*! rollup-include-esm-only-end */
 }

packages/node/src/utils/detection.ts

@@ -7,6 +7,7 @@ function isCjs(): boolean {
   /*! rollup-include-cjs-only-end */
 
   /*! rollup-include-esm-only */
+  // oxlint-disable-next-line no-unreachable -- reachable only in the ESM build; rollup strips the CJS return above
   return false;
   /*! rollup-include-esm-only-end */
 }

packages/server-utils/src/integrations/tracing-channel/firebase/instrumentation.ts

@@ -61,7 +61,7 @@ export function instrumentFirebase() {
     // span inside that wrapper. The other lifecycle events are irrelevant, so no-op them.
     diagnosticsChannel.tracingChannel(channel).subscribe({
       start: data =>
-        void safeChannelCallback(() => wrapFunctionsRegistration(data as { arguments: unknown[] }, triggerType)),
+        safeChannelCallback(() => wrapFunctionsRegistration(data as { arguments: unknown[] }, triggerType)),
       end: NOOP,
       asyncStart: NOOP,
       asyncEnd: NOOP,

packages/server-utils/src/integrations/tracing-channel/graphql/index.ts

@@ -53,13 +53,13 @@ const _graphqlChannelIntegration = ((options: GraphqlDiagnosticChannelsOptions =
         bindTracingChannelToSpan(
           diagnosticsChannel.tracingChannel<GraphqlChannelContext>(CHANNELS.GRAPHQL_VALIDATE),
           data => safeChannelCallback(() => startValidateSpan(data.arguments[1])),
-          { beforeSpanEnd: (span, data) => void safeChannelCallback(() => finalizeValidateSpan(span, data.result)) },
+          { beforeSpanEnd: (span, data) => safeChannelCallback(() => finalizeValidateSpan(span, data.result)) },
         );
 
         bindTracingChannelToSpan(
           diagnosticsChannel.tracingChannel<GraphqlChannelContext>(CHANNELS.GRAPHQL_EXECUTE),
           data => safeChannelCallback(() => startExecuteSpan(data.arguments, data.self, config, getConfig)),
-          { beforeSpanEnd: (span, data) => void safeChannelCallback(() => finalizeExecuteSpan(span, data.result)) },
+          { beforeSpanEnd: (span, data) => safeChannelCallback(() => finalizeExecuteSpan(span, data.result)) },
         );
       });
     },