ref: Add sampling to span first (11) #11836
test-integrations-common.yml
on: pull_request
Matrix: Common
All Common tests passed
4s
Annotations
29 warnings
|
Baggage mutated without checking mutable flag:
sentry_sdk/scope.py#L1254
The `_update_sample_rate` method (lines 1248-1255) directly mutates `baggage.sentry_items["sample_rate"]` without checking the `baggage.mutable` flag first. The Baggage class docstring explicitly states: "Before mutating a Baggage object, calling code must check that mutable is True." When baggage is received from an upstream trace via `from_incoming_header`, it is marked as immutable (`mutable=False`). Mutating immutable baggage violates the class contract and could lead to incorrect sampling rate propagation if the original rate should have been preserved.
|
|
Common (3.6, ubuntu-22.04)
❌ Patch coverage check failed: 4.48% < target 80%
|
|
Common (3.7, ubuntu-22.04)
❌ Patch coverage check failed: 4.48% < target 80%
|
|
Common (3.7, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.7, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.10, ubuntu-22.04)
❌ Patch coverage check failed: 4.48% < target 80%
|
|
Common (3.10, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.10, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.8, ubuntu-22.04)
❌ Patch coverage check failed: 4.48% < target 80%
|
|
Common (3.8, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.8, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.11, ubuntu-22.04)
❌ Patch coverage check failed: 4.48% < target 80%
|
|
Common (3.11, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.11, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.9, ubuntu-22.04)
❌ Patch coverage check failed: 4.48% < target 80%
|
|
Common (3.9, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.9, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.12, ubuntu-22.04)
❌ Patch coverage check failed: 4.48% < target 80%
|
|
Common (3.12, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.12, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.13, ubuntu-22.04)
❌ Patch coverage check failed: 4.48% < target 80%
|
|
Common (3.13, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.13, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.14, ubuntu-22.04)
❌ Patch coverage check failed: 4.48% < target 80%
|
|
Common (3.14, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.14, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.14t, ubuntu-22.04)
❌ Patch coverage check failed: 4.48% < target 80%
|
|
Common (3.14t, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Common (3.14t, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
codecov-coverage-results-ivana-span-first-11-sampling-test-common
Expired
|
99.6 KB |
sha256:a5fe41dc6965a79846fd9c752a425afc49b13a82fb80d1d3d37dbf2a65f0b534
|
|
|
codecov-test-results-ivana-span-first-11-sampling-test-common
Expired
|
244 Bytes |
sha256:42615a1d5ca536420fd8a4d5edf31dee0732d2102240f437900e8fe1141f6a87
|
|