feat(huey): Add messaging.destination.name attribute to producer spans

Author: alexander-alderman-webb

sentry_sdk/integrations/huey.py

@@ -4,7 +4,7 @@
 
 import sentry_sdk
 from sentry_sdk.api import continue_trace, get_baggage, get_traceparent
-from sentry_sdk.consts import OP, SPANSTATUS
+from sentry_sdk.consts import OP, SPANDATA, SPANSTATUS
 from sentry_sdk.integrations import DidNotEnable, Integration
 from sentry_sdk.scope import should_send_default_pii
 from sentry_sdk.traces import SegmentSource, SpanStatus, StreamedSpan
@@ -86,6 +86,7 @@ def _sentry_enqueue(
                 attributes={
                     "sentry.op": OP.QUEUE_SUBMIT_HUEY,
                     "sentry.origin": HueyIntegration.origin,
+                    SPANDATA.MESSAGING_DESTINATION_NAME: self.name,
                 },
             )
         else:
@@ -94,6 +95,7 @@ def _sentry_enqueue(
                 name=span_name,
                 origin=HueyIntegration.origin,
             )
+            span_ctx.set_data(SPANDATA.MESSAGING_DESTINATION_NAME, self.name)
 
         no_headers_types = (PeriodicTask,) + tuple(
             t for t in [HueyGroup, HueyChord] if t is not None

tests/integrations/huey/test_huey.py

@@ -7,7 +7,7 @@
 
 import sentry_sdk
 from sentry_sdk import start_transaction
-from sentry_sdk.consts import OP
+from sentry_sdk.consts import OP, SPANDATA
 from sentry_sdk.integrations.huey import HueyIntegration
 from sentry_sdk.traces import SegmentSource, SpanStatus
 from sentry_sdk.utils import parse_version
@@ -97,6 +97,9 @@ def division(a, b):
         enqueue_span, execute_span = payloads
 
         assert enqueue_span["attributes"]["sentry.op"] == OP.QUEUE_SUBMIT_HUEY
+        assert (
+            enqueue_span["attributes"][SPANDATA.MESSAGING_DESTINATION_NAME] == huey.name
+        )
         assert execute_span["is_segment"]
         assert execute_span["attributes"]["sentry.op"] == OP.QUEUE_TASK_HUEY
         assert execute_span["name"] == "division"
@@ -308,6 +311,7 @@ def dummy_task():
     assert len(event["spans"])
     assert event["spans"][0]["op"] == "queue.submit.huey"
     assert event["spans"][0]["description"] == "different_task_name"
+    assert event["spans"][0]["data"][SPANDATA.MESSAGING_DESTINATION_NAME] == huey.name
 
 
 def test_huey_propagate_trace(init_huey, capture_events):