feat(falcon): Set name and source on request span when streaming

Author: alexander-alderman-webb

sentry_sdk/integrations/falcon.py

@@ -104,6 +104,22 @@ def process_request(
         scope._name = "falcon"
         scope.add_event_processor(_make_request_event_processor(req, integration))
 
+    def process_resource(
+        self, req: "Any", resp: "Any", resource: "Any", params: "Any"
+    ) -> None:
+        integration = sentry_sdk.get_client().get_integration(FalconIntegration)
+        if integration is None:
+            return
+
+        name_for_style = {
+            "uri_template": req.uri_template,
+            "path": req.path,
+        }
+        name = name_for_style[integration.transaction_style]
+        source = SOURCE_FOR_STYLE[integration.transaction_style]
+        sentry_sdk.set_transaction_name(name, source)
+        sentry_sdk.get_isolation_scope().set_transaction_name(name, source)
+
 
 TRANSACTION_STYLE_VALUES = ("uri_template", "path")
 
@@ -233,23 +249,10 @@ def _has_http_5xx_status(response: "falcon.Response") -> bool:
     return response.status.startswith("5")
 
 
-def _set_transaction_name_and_source(
-    event: "Event", transaction_style: str, request: "falcon.Request"
-) -> None:
-    name_for_style = {
-        "uri_template": request.uri_template,
-        "path": request.path,
-    }
-    event["transaction"] = name_for_style[transaction_style]
-    event["transaction_info"] = {"source": SOURCE_FOR_STYLE[transaction_style]}
-
-
 def _make_request_event_processor(
     req: "falcon.Request", integration: "FalconIntegration"
 ) -> "EventProcessor":
     def event_processor(event: "Event", hint: "dict[str, Any]") -> "Event":
-        _set_transaction_name_and_source(event, integration.transaction_style, req)
-
         with capture_internal_exceptions():
             FalconRequestExtractor(req).extract_into_event(event)
 

tests/integrations/falcon/test_falcon.py

@@ -121,24 +121,35 @@ def test_transaction_style(
     integration = FalconIntegration(transaction_style=transaction_style)
     sentry_init(
         integrations=[integration],
+        traces_sample_rate=1.0,
         _experiments={"trace_lifecycle": "stream" if span_streaming else "static"},
     )
 
     client = make_client()
     if span_streaming:
-        items = capture_items("event")
+        items = capture_items("event", "span")
 
         response = client.simulate_get(url)
         assert response.status == falcon.HTTP_200
 
-        (event,) = (item.payload for item in items)
+        (event,) = (item.payload for item in items if item.type == "event")
+
+        sentry_sdk.flush()
+        spans = [item.payload for item in items if item.type == "span"]
+        spans = [span for span in spans if span["name"] == expected_transaction]
+        assert len(spans) == 1
+        assert spans[0]["attributes"]["sentry.span.source"] == expected_source
     else:
         events = capture_events()
 
         response = client.simulate_get(url)
         assert response.status == falcon.HTTP_200
 
-        (event,) = events
+        (event, transaction) = events
+
+        assert transaction["transaction"] == expected_transaction
+        assert transaction["transaction_info"] == {"source": expected_source}
+
     assert event["transaction"] == expected_transaction
     assert event["transaction_info"] == {"source": expected_source}