fix: modernize Digest::file and document digest_file_ctx#12
Closed
toddr-bot wants to merge 21 commits into
Closed
Conversation
Drop use vars
- meta-spec 2 resources format - dependencies are static, set dynamic_config 0 - EUMM will set configure_requires on itself - Test::More only used in tests - boilerplate to clean out unsupported keys if installed with old EUMM
Makefile.PL - use meta-spec 2, fix prereqs, compatibility with old EUMM
base.t, file.t: unlink temporary files created during testing
Ignore common temp files in repo.
Replace legacy @ISA-based Exporter inheritance with 'use parent', completing the modernization that was partially done in v1.18. Document digest_file_ctx() in POD — it was exported but invisible to users reading the documentation. Add direct test coverage for digest_file_ctx including error handling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Superseded by #13, which combines all three improvements (DESTROY guard, Digest::file modernization, digest_file_ctx documentation). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Modernize
Digest::filemodule: replace legacy@ISAinheritance withuse parent, add POD documentation for the exported-but-undocumenteddigest_file_ctx()function, and add direct test coverage.Why
Digest::filewas the last module still using@ISA = qw(Exporter)— the other modules were modernized in v1.18 (partially addressing guillemj's upstream PR #4). Thedigest_file_ctxfunction has been exported via@EXPORT_OKsince its introduction, but was never documented in the POD, making it invisible to users who read the documentation.How
use Exporter (); @ISA = qw(Exporter)withuse parent 'Exporter'— cleaner, declarative, and consistent with modern Perl styledigest_file_ctxdocumentation to the POD section alongside the existing 3 functionsisa_okand digest verification fordigest_file_ctx, plus error handling for missing filesTesting
prove -l t/— all 27 tests pass across 4 test files.🤖 Generated with Claude Code