First time contribution #12727
Unanswered
willemneal
asked this question in
Q&A
Replies: 1 comment 1 reply
-
|
Thanks for taking the opportunity to contribute, and one PR per crate would certainly be my preference as the easier-to-review option. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I've been very interested in
butmcp and generally having agents collaborate in a workspace. When reviewing the code I noticed some unnecessary allocations. So then decided to use this as opportunity to dog food this. I still found it too sequential, but I ended up with a workspace where each crate is its own branch with the relevant refactors.So my question is would it be better to submit the fixes as one PR per crate? Or one PR with all of the crates?
Beta Was this translation helpful? Give feedback.
All reactions