Test inputs.configFile mutation in tests

Author: mbg

src/config-utils.test.ts

@@ -2317,22 +2317,25 @@ test("determineUserConfig - loads config file", async (t) => {
     const logger = new RecordingLogger();
     const env = util.getEnv(DEFAULT_ACTIONS_VARS);
 
+    const inputs = createTestInitConfigInputs({
+      configInput: undefined,
+      configFile: configFilePath,
+    });
     const result = await configUtils.determineUserConfig(
       logger,
       env,
       createFeatures([]),
       tmpDir,
-      createTestInitConfigInputs({
-        configInput: undefined,
-        configFile: configFilePath,
-      }),
+      inputs,
     );
 
     // The loaded configuration should match `simpleConfigFileContents`.
     t.deepEqual(result, {
       name: "my config",
       queries: [{ uses: "./foo_file" }],
     });
+    // The `configFile` input should not have changed.
+    t.is(inputs.configFile, configFilePath);
     // And the path of the input config file should have been logged, while the
     // other two origin messages should not have been logged.
     t.true(logger.hasMessage(`Using configuration file: ${configFilePath}`));
@@ -2351,30 +2354,32 @@ test("determineUserConfig - loads config input", async (t) => {
   await withTmpDir(async (tmpDir) => {
     const logger = new RecordingLogger();
     const env = util.getEnv(DEFAULT_ACTIONS_VARS);
+    const expectedConfigPath = configUtils.userConfigFromActionPath(tmpDir);
 
+    const inputs = createTestInitConfigInputs({
+      configInput: simpleConfigFileContents,
+      configFile: undefined,
+    });
     const result = await configUtils.determineUserConfig(
       logger,
       env,
       createFeatures([]),
       tmpDir,
-      createTestInitConfigInputs({
-        configInput: simpleConfigFileContents,
-        configFile: undefined,
-      }),
+      inputs,
     );
 
     // The loaded configuration should match `simpleConfigFileContents`.
     t.deepEqual(result, {
       name: "my config",
       queries: [{ uses: "./foo_file" }],
     });
+    // The `configFile` input should have been mutated to the generated path.
+    t.is(inputs.configFile, expectedConfigPath);
     // And the input source and path of the generated config file should have been logged,
     // while the message about no configuration input should not have been logged.
     t.true(logger.hasMessage("Using config from action input:"));
     t.true(
-      logger.hasMessage(
-        `Using configuration file: ${configUtils.userConfigFromActionPath(tmpDir)}`,
-      ),
+      logger.hasMessage(`Using configuration file: ${expectedConfigPath}`),
     );
     t.false(logger.hasMessage("No configuration file was provided"));
     // But the warning about both inputs should not have been logged.
@@ -2393,22 +2398,25 @@ test("determineUserConfig - ignores config file input when both specified", asyn
     const configFilePath = createConfigFile(otherConfigFileContents, tmpDir);
     const expectedConfigPath = configUtils.userConfigFromActionPath(tmpDir);
 
+    const inputs = createTestInitConfigInputs({
+      configInput: simpleConfigFileContents,
+      configFile: configFilePath,
+    });
     const result = await configUtils.determineUserConfig(
       logger,
       env,
       createFeatures([]),
       tmpDir,
-      createTestInitConfigInputs({
-        configInput: simpleConfigFileContents,
-        configFile: configFilePath,
-      }),
+      inputs,
     );
 
     // The loaded configuration should match `simpleConfigFileContents`.
     t.deepEqual(result, {
       name: "my config",
       queries: [{ uses: "./foo_file" }],
     });
+    // The `configFile` input should have been mutated to the generated path.
+    t.is(inputs.configFile, expectedConfigPath);
     // And the path of the generated config file should have been logged.
     t.true(
       logger.hasMessage(