Address review comments

Author: lcartey

change_notes/2024-06-03-constexpr-variable.md

@@ -1,3 +1,2 @@
  - `A7-1-2` - `VariableMissingConstexpr.ql`:
-   - Remove false positives for compiler generated variables
-   - Remove results in uninstantiated templates that cause false positives
+   - Fixes #607. Remove false positives for compiler generated variables and in uninstantiated templates

cpp/autosar/src/rules/A7-1-2/VariableMissingConstexpr.ql

@@ -67,4 +67,4 @@ where
   not v.isFromUninstantiatedTemplate(_) and
   // Exclude compiler generated variables, which are not user controllable
   not v.isCompilerGenerated()
-select v, "Variable " + v.getName() + " could be marked 'constexpr'."
+select v, "Variable '" + v.getName() + "' could be marked 'constexpr'."

cpp/autosar/test/rules/A7-1-2/test.cpp

@@ -266,14 +266,12 @@ constexpr void fp_reported_in_466(int p) {
       add4(1, l3); // COMPLIANT - l3 is not compile time constant on all paths
 }
 
-template <typename T> T* init(T** t) { }
+template <typename T> T *init(T **t) {}
 
-template <typename T> T* init() {
- T* t = nullptr; // COMPLIANT - initialized below
- init(&t); // Init is ignored in uninitialized template
- return t;
+template <typename T> T *init() {
+  T *t = nullptr; // COMPLIANT - initialized below
+  init(&t);       // Init is ignored in uninitialized template
+  return t;
 }
 
-void test_template_instantiation() {
-  int* t = init<int>();
-}
+void test_template_instantiation() { int *t = init<int>(); }