Skip to content

Commit 016808b

Browse files
author
Max Schaefer
committed
JavaScript: Address review comments.
1 parent 3bbded5 commit 016808b

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

change-notes/1.23/analysis-javascript.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131

3232
| **Query** | **Expected impact** | **Change** |
3333
|--------------------------------|------------------------------|---------------------------------------------------------------------------|
34+
| Double escaping or unescaping (`js/double-escaping`) | More results | This rule now detects additional escaping and unescaping functions. |
3435
| Incomplete string escaping or encoding (`js/incomplete-sanitization`) | Fewer false-positive results | This rule now recognizes additional ways delimiters can be stripped away. |
3536
| Client-side cross-site scripting (`js/xss`) | More results, fewer false-positive results | More potential vulnerabilities involving functions that manipulate DOM attributes are now recognized, and more sanitizers are detected. |
3637
| Code injection (`js/code-injection`) | More results | More potential vulnerabilities involving functions that manipulate DOM event handler attributes are now recognized. |

javascript/ql/src/Security/CWE-116/DoubleEscaping.qhelp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ attacks such as cross-site scripting. One particular example of this is HTML ent
1010
where HTML special characters are replaced by HTML character entities to prevent them from being
1111
interpreted as HTML markup. For example, the less-than character is encoded as <code>&amp;lt;</code>
1212
and the double-quote character as <code>&amp;quot;</code>.
13-
Other examples include backslash-escaping for including untrusted data in string literals and
14-
percent-encoding for URI components.
13+
Other examples include backslash escaping or JSON encoding for including untrusted data in string
14+
literals, and percent-encoding for URI components.
1515
</p>
1616
<p>
1717
The reverse process of replacing escape sequences with the characters they represent is known as

0 commit comments

Comments
 (0)