Replaces name-reference to the class with canonical predicate.

BekaValentine · BekaValentine · commit 28be3b47fc96 · 2020-02-20T15:41:51.000-08:00
diff --git a/python/ql/src/Expressions/TruncatedDivision.ql b/python/ql/src/Expressions/TruncatedDivision.ql
@@ -29,10 +29,9 @@ where
         and not lval.(NumericValue).intValue() % rval.(NumericValue).intValue() = 0
         and not bin.getNode().getEnclosingModule().hasFromFuture("division")
         // Filter out results wrapped in `int(...)`
-        and not exists(CallNode c, ClassValue cls |
-            c.getAnArg() = bin
-            and c.getFunction().pointsTo(cls)
-            and cls.getName() = "int"
+        and not exists(CallNode c |
+            c = ClassValue::int_().getACall()
+            and c.getAnArg() = bin
         )
     )
 select div, "Result of division may be truncated as its $@ and $@ arguments may both be integers.",

Original file line number	Diff line number	Diff line change
`@@ -29,10 +29,9 @@ where`
`29`	`29`	`and not lval.(NumericValue).intValue() % rval.(NumericValue).intValue() = 0`
`30`	`30`	`and not bin.getNode().getEnclosingModule().hasFromFuture("division")`
`31`	`31`	// Filter out results wrapped in `int(...)`
`32`		`- and not exists(CallNode c, ClassValue cls \|`
`33`		`- c.getAnArg() = bin`
`34`		`- and c.getFunction().pointsTo(cls)`
`35`		`- and cls.getName() = "int"`
	`32`	`+ and not exists(CallNode c \|`
	`33`	`+ c = ClassValue::int_().getACall()`
	`34`	`+ and c.getAnArg() = bin`
`36`	`35`	`)`
`37`	`36`	`)`
`38`	`37`	`select div, "Result of division may be truncated as its $@ and $@ arguments may both be integers.",`