Skip to content

Commit 2a0e004

Browse files
committed
add "good" test cases to demonstrate false positives
1 parent 6c52de9 commit 2a0e004

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

python/ql/test/query-tests/Security/CWE-117-LogInjection/LogInjectionGood.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,18 @@ def good1():
1818
logging.info('User name: ' + name) # Good
1919
return 'good1'
2020

21+
@app.route('/good_repr1')
22+
def good_repr1():
23+
name = request.args.get('name')
24+
logging.info('User name: ' + repr(name)) # Good - repr() escapes special characters
25+
return 'good_repr1'
26+
27+
@app.route('/good_repr2')
28+
def good_repr2():
29+
name = request.args.get('name')
30+
logging.info('User name: %r', name) # Good - %r format specifier applies repr()
31+
return 'good_repr2'
32+
2133
if __name__ == '__main__':
2234
app.debug = True
2335
handler = logging.FileHandler('log')

0 commit comments

Comments
 (0)