Skip to content

Commit 2b9eef5

Browse files
authored
Merge pull request #22334 from github/redsun82-android-8-sample-arm-gating
Gate remaining Android integration tests off linux-arm64
2 parents 8bc3240 + 2c67a08 commit 2b9eef5

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

  • java/ql/integration-tests/java
    • android-8-sample
    • diagnostics/android-gradle-incompatibility
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1+
import runs_on
2+
3+
14
# Put Java 11 on the path so as to challenge our version selection logic: Java 11 is unsuitable for Android Gradle Plugin 8+,
25
# so it will be necessary to notice Java 17 available in the environment and actively select it.
6+
# This Android Gradle Plugin version ships no linux-aarch64 aapt2, so the build fails on linux-arm64 (macOS arm64 works).
7+
@(runs_on.x86_64 or runs_on.macos)
38
def test(codeql, use_java_11, java, gradle_8_0, android_sdk):
49
codeql.database.create()
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,7 @@
1+
import runs_on
2+
3+
4+
# Deselected on linux-arm64: there the AGP build fails because no linux-aarch64 aapt2 exists, which is unrelated to the AGP/Gradle version incompatibility this test asserts and would otherwise let it pass for the wrong reason.
5+
@(runs_on.x86_64 or runs_on.macos)
16
def test(codeql, java, gradle_7_3, android_sdk):
27
codeql.database.create(_assert_failure=True)

0 commit comments

Comments
 (0)