C#: Update the NoDisposeCallOnLocalIDisposable and expected output.

Author: michaelnebel

csharp/ql/test/query-tests/API Abuse/NoDisposeCallOnLocalIDisposable/NoDisposeCallOnLocalIDisposable.cs

@@ -70,12 +70,12 @@ public IDisposable Method()
         using (var reader = new StreamReader(new FileStream("", FileMode.Open)))
             ;
 
-        // GOOD: XmlDocument.Load disposes incoming XmlReader (according to CIL)
+        // GOOD: XmlDocument.Load disposes incoming XmlReader (False positive as this is disposed in library code)
         var xmlReader = XmlReader.Create(new StringReader("xml"), null);
         var xmlDoc = new XmlDocument();
         xmlDoc.Load(xmlReader);
 
-        // GOOD: Passed to a library. This is only detected in CIL.
+        // GOOD: Passed to a library (False positive as this is disposed in library code).
         DisposalTests.Class1.Dispose(new StreamWriter("output.txt"));
 
         // GOOD: Disposed automatically.

csharp/ql/test/query-tests/API Abuse/NoDisposeCallOnLocalIDisposable/NoDisposeCallOnLocalIDisposable.expected

@@ -2,4 +2,6 @@
 | NoDisposeCallOnLocalIDisposable.cs:51:18:51:73 | object creation of type FileStream | Disposable 'FileStream' is created but not disposed. |
 | NoDisposeCallOnLocalIDisposable.cs:52:9:52:64 | object creation of type FileStream | Disposable 'FileStream' is created but not disposed. |
 | NoDisposeCallOnLocalIDisposable.cs:74:25:74:71 | call to method Create | Disposable 'XmlReader' is created but not disposed. |
+| NoDisposeCallOnLocalIDisposable.cs:74:42:74:64 | object creation of type StringReader | Disposable 'StringReader' is created but not disposed. |
+| NoDisposeCallOnLocalIDisposable.cs:79:38:79:67 | object creation of type StreamWriter | Disposable 'StreamWriter' is created but not disposed. |
 | NoDisposeCallOnLocalIDisposableBad.cs:8:22:8:56 | object creation of type FileStream | Disposable 'FileStream' is created but not disposed. |

csharp/ql/test/query-tests/API Abuse/NoDisposeCallOnLocalIDisposable/options

@@ -1 +1 @@
-semmle-extractor-options: --cil /r:System.Private.Xml.dll /r:System.IO.Compression.dll
+semmle-extractor-options: /r:System.Private.Xml.dll /r:System.IO.Compression.dll