Skip to content

Commit 4406065

Browse files
committed
QL: QL: Respond to PR reviews.
1 parent dd6abdc commit 4406065

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

ql/src/queries/style/SuperfluousExists.ql

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ predicate exprImpliesExists(ValueNumber vn, Expr e) {
5151
or
5252
exprImpliesExists(vn, e.(AsExpr).getInnerExpr())
5353
or
54-
exprImpliesExists(vn, e.(Range).getAnEndpoint())
55-
or
5654
exists(ExprAggregate agg |
5755
agg = e and
5856
agg.getKind().matches(["strict%", "unique"]) and
@@ -71,9 +69,8 @@ predicate formulaImpliesExists(ValueNumber vn, Formula f) {
7169
or
7270
exprImpliesExists(vn, f.(ComparisonFormula).getAnOperand())
7371
or
74-
exists(IfFormula ifFormula | ifFormula = f |
75-
exprImpliesExists(vn, ifFormula.getCondition())
76-
or
72+
exists(IfFormula ifFormula |
73+
ifFormula = f and
7774
formulaImpliesExists(vn, ifFormula.getThenPart()) and
7875
formulaImpliesExists(vn, ifFormula.getElsePart())
7976
)

0 commit comments

Comments
 (0)