Skip to content

Commit 48910d0

Browse files
yofftausbn
andauthored
Apply suggestions from code review
Co-authored-by: Taus <tausbn@github.com>
1 parent dfdfd3c commit 48910d0

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

python/ql/src/semmle/python/dataflow/new/internal/DataFlowPrivate.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1049,7 +1049,7 @@ predicate subscriptReadStep(CfgNode nodeFrom, Content c, CfgNode nodeTo) {
10491049
* (a, *b) = ("a", "b", "tainted string") # RHS has content `TupleElement(2)`
10501050
* ```
10511051
* Since the starred variables are always assigned type list, `*b` will be
1052-
* `["b", "tainted string]`, and we will agsin overapproximate and assign it
1052+
* `["b", "tainted string]`, and we will again overapproximate and assign it
10531053
* content corresponding to anything found in the RHS.
10541054
*
10551055
* For a precise transfer
@@ -1103,7 +1103,7 @@ predicate subscriptReadStep(CfgNode nodeFrom, Content c, CfgNode nodeTo) {
11031103
*
11041104
* 1. [Flow, Read, Store] The last 5 steps are repeated for all recursive elements which are sequences.
11051105
*/
1106-
module unpackinAssignment {
1106+
module UnpackingAssignment {
11071107
/** A direct (or top-level) target of an unpacking assignment */
11081108
class UnpackingAssignmentDirectTarget extends ControlFlowNode {
11091109
Expr value;
@@ -1121,7 +1121,7 @@ module unpackinAssignment {
11211121
UnpackingAssignmentTarget() {
11221122
this instanceof UnpackingAssignmentDirectTarget
11231123
or
1124-
exists(UnpackingAssignmentTarget parent | this = parent.getAnElement())
1124+
this = any(UnpackingAssignmentTarget parent).getAnElement()
11251125
}
11261126

11271127
ControlFlowNode getElement(int i) { result = this.(SequenceNode).getElement(i) }
@@ -1227,7 +1227,7 @@ module unpackinAssignment {
12271227
}
12281228
}
12291229

1230-
import unpackinAssignment
1230+
import UnpackingAssignment
12311231

12321232
/** Data flows from a sequence to a call to `pop` on the sequence. */
12331233
predicate popReadStep(CfgNode nodeFrom, Content c, CfgNode nodeTo) {

0 commit comments

Comments
 (0)