Update java/ql/src/experimental/Security/CWE/CWE-470/UnsafeReflection.ql

haby0 · smowton · haby0 · commit 676f0ad817bb · 2021-07-22T21:45:29.000+08:00
Co-authored-by: Chris Smowton &lt;smowton@github.com&gt;
diff --git a/java/ql/src/experimental/Security/CWE/CWE-470/UnsafeReflection.ql b/java/ql/src/experimental/Security/CWE/CWE-470/UnsafeReflection.ql
@@ -27,7 +27,7 @@ class EqualsSanitizer extends DataFlow::BarrierGuard {
   EqualsSanitizer() { this.(MethodAccess).getMethod().hasName("equals") }
 
   override predicate checks(Expr e, boolean branch) {
-    (e = this.(MethodAccess).getArgument(0) or e = this.(MethodAccess).getQualifier()) and
+    e = [this.(MethodAccess).getArgument(0), this.(MethodAccess).getQualifier()] and
     branch = true
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ class EqualsSanitizer extends DataFlow::BarrierGuard {`
`27`	`27`	`EqualsSanitizer() { this.(MethodAccess).getMethod().hasName("equals") }`
`28`	`28`
`29`	`29`	`override predicate checks(Expr e, boolean branch) {`
`30`		`- (e = this.(MethodAccess).getArgument(0) or e = this.(MethodAccess).getQualifier()) and`
	`30`	`+ e = [this.(MethodAccess).getArgument(0), this.(MethodAccess).getQualifier()] and`
`31`	`31`	`branch = true`
`32`	`32`	`}`
`33`	`33`	`}`