C#: Change array-returning properties

Author: tamasvajk

csharp/autobuilder/Semmle.Autobuild.CSharp/StandaloneBuildRule.cs

@@ -1,4 +1,5 @@
-using Semmle.Autobuild.Shared;
+using System.Linq;
+using Semmle.Autobuild.Shared;
 
 namespace Semmle.Autobuild.CSharp
 {
@@ -44,9 +45,7 @@ BuildScript GetCommand(string? solution)
             if (!builder.Options.Buildless)
                 return BuildScript.Failure;
 
-            var solutions = builder.Options.Solution.Length;
-
-            if (solutions == 0)
+            if (!builder.Options.Solution.Any())
                 return GetCommand(null);
 
             var script = BuildScript.Success;

csharp/autobuilder/Semmle.Autobuild.Shared/AutobuildOptions.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Text.RegularExpressions;
 
@@ -21,7 +22,7 @@ public class AutobuildOptions
         public string? DotNetArguments { get; }
         public string? DotNetVersion { get; }
         public string? BuildCommand { get; }
-        public string[] Solution { get; }
+        public IEnumerable<string> Solution { get; }
         public bool IgnoreErrors { get; }
         public bool Buildless { get; }
         public bool AllSolutions { get; }

csharp/extractor/Semmle.Extraction.CSharp/Analyser.cs

@@ -52,7 +52,7 @@ public Analyser(IProgressMonitor pm, ILogger logger, bool addAssemblyTrapPrefix,
         /// </summary>
         /// <param name="roslynArgs">The arguments passed to Roslyn.</param>
         /// <returns>A Boolean indicating whether to proceed with extraction.</returns>
-        public bool BeginInitialize(string[] roslynArgs)
+        public bool BeginInitialize(IEnumerable<string> roslynArgs)
         {
             return init = LogRoslynArgs(roslynArgs, Extraction.Extractor.Version);
         }
@@ -447,7 +447,7 @@ public void LogExtractorInfo(string extractorVersion)
         /// </summary>
         /// <param name="roslynArgs">The arguments passed to Roslyn.</param>
         /// <returns>A Boolean indicating whether the same arguments have been logged previously.</returns>
-        public bool LogRoslynArgs(string[] roslynArgs, string extractorVersion)
+        private bool LogRoslynArgs(IEnumerable<string> roslynArgs, string extractorVersion)
         {
             LogExtractorInfo(extractorVersion);
             Logger.Log(Severity.Info, $"  Arguments to Roslyn: {string.Join(' ', roslynArgs)}");

csharp/extractor/Semmle.Extraction.CSharp/CompilerVersion.cs

@@ -134,6 +134,6 @@ private static bool SuppressDefaultResponseFile(IEnumerable<string> args)
             return args.Any(arg => new[] { "/noconfig", "-noconfig" }.Contains(arg.ToLowerInvariant()));
         }
 
-        public string[] ArgsWithResponse { get; }
+        public IEnumerable<string> ArgsWithResponse { get; }
     }
 }

csharp/extractor/Semmle.Extraction.CSharp/Entities/Types/Nullability.cs

@@ -10,7 +10,7 @@ public sealed class Nullability
         public int Annotation { get; }
 
         private static readonly Nullability[] emptyArray = System.Array.Empty<Nullability>();
-        public Nullability[] NullableParameters { get; }
+        public IEnumerable<Nullability> NullableParameters { get; }
 
         public static Nullability Create(AnnotatedTypeSymbol ts)
         {
@@ -30,7 +30,7 @@ public static Nullability Create(AnnotatedTypeSymbol ts)
             return new Nullability(ts);
         }
 
-        public bool IsOblivious => Annotation == 0 && NullableParameters.Length == 0;
+        public bool IsOblivious => Annotation == 0 && !NullableParameters.Any();
 
         private static readonly Nullability oblivious = new Nullability(NullableAnnotation.None);
         private static readonly Nullability annotated = new Nullability(NullableAnnotation.Annotated);