Improve logging, expose inherited feeds in integration test

Author: tamasvajk

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependencyManager.Nuget.cs

@@ -522,7 +522,6 @@ private bool CheckFeeds(List<FileInfo> allFiles)
         {
             logger.LogInfo("Checking Nuget feeds...");
             var (explicitFeeds, allFeeds) = GetAllFeeds(allFiles);
-            var inheritedFeeds = allFeeds.Except(explicitFeeds).ToHashSet();
 
             var excludedFeeds = EnvironmentVariables.GetURLs(EnvironmentVariableNames.ExcludedNugetFeedsFromResponsivenessCheck)
                 .ToHashSet() ?? [];
@@ -549,9 +548,11 @@ private bool CheckFeeds(List<FileInfo> allFiles)
             }
             CompilationInfos.Add(("All Nuget feeds reachable", allFeedsReachable ? "1" : "0"));
 
+
+            var inheritedFeeds = allFeeds.Except(explicitFeeds).ToHashSet();
             if (inheritedFeeds.Count > 0)
             {
-                logger.LogInfo($"Inherited Nuget feeds: {string.Join(", ", inheritedFeeds.OrderBy(f => f))}");
+                logger.LogInfo($"Inherited Nuget feeds (not checked for reachability): {string.Join(", ", inheritedFeeds.OrderBy(f => f))}");
                 CompilationInfos.Add(("Inherited Nuget feed count", inheritedFeeds.Count.ToString()));
             }
 

csharp/ql/integration-tests/posix-only/standalone_dependencies_nuget_config_error_timeout/CompilationInfo.expected

@@ -1,5 +1,6 @@
 | All Nuget feeds reachable | 0.0 |
 | Fallback nuget restore | 1.0 |
+| Inherited Nuget feed count | 1.0 |
 | Project files on filesystem | 1.0 |
 | Resolved assembly conflicts | 7.0 |
 | Restored .NET framework variants | 0.0 |

csharp/ql/integration-tests/posix-only/standalone_dependencies_nuget_config_error_timeout/proj/nuget.config

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <configuration>
   <packageSources>
-    <clear />
+    <!-- <clear /> -->
     <add key="x" value="https://localhost:53/packages/" />
     <add key="y" value="https://localhost:80/packages/" />
   </packageSources>