C#: Only include source code nodes in the identity local step consistency check.

michaelnebel · michaelnebel · commit 75ea449147b4 · 2023-05-11T10:49:39.000+02:00
diff --git a/csharp/ql/consistency-queries/DataFlowConsistency.ql b/csharp/ql/consistency-queries/DataFlowConsistency.ql
@@ -72,5 +72,5 @@ private class MyConsistencyConfiguration extends ConsistencyConfiguration {
 
   override predicate reverseReadExclude(Node n) { n.asExpr() = any(AwaitExpr ae).getExpr() }
 
-  override predicate identityLocalStepExclude(Node n) { this.missingLocationExclude(n) }
+  override predicate identityLocalStepExclude(Node n) { n.getLocation().getFile().fromLibrary() }
 }

Original file line number	Diff line number	Diff line change
`@@ -72,5 +72,5 @@ private class MyConsistencyConfiguration extends ConsistencyConfiguration {`
`72`	`72`
`73`	`73`	`override predicate reverseReadExclude(Node n) { n.asExpr() = any(AwaitExpr ae).getExpr() }`
`74`	`74`
`75`		`- override predicate identityLocalStepExclude(Node n) { this.missingLocationExclude(n) }`
	`75`	`+ override predicate identityLocalStepExclude(Node n) { n.getLocation().getFile().fromLibrary() }`
`76`	`76`	`}`