Python: Autoformat twisted library

Author: RasmusWL

python/ql/src/semmle/python/web/twisted/Request.qll

@@ -1,53 +1,35 @@
 import python
-
 import semmle.python.security.TaintTracking
 import semmle.python.web.Http
 import Twisted
 
 /** A twisted.web.http.Request object */
 class TwistedRequest extends TaintKind {
-
-    TwistedRequest() {
-        this = "twisted.request.http.Request"
-    }
+    TwistedRequest() { this = "twisted.request.http.Request" }
 
     override TaintKind getTaintOfAttribute(string name) {
         result instanceof ExternalStringSequenceDictKind and
-        (
-            name = "args"
-        )
+        name = "args"
         or
         result instanceof ExternalStringKind and
-        (
-            name = "uri"
-        )
+        name = "uri"
     }
 
     override TaintKind getTaintOfMethodResult(string name) {
-            (
-                name = "getHeader" or
-                name = "getCookie" or
-                name = "getUser" or
-                name = "getPassword"
-            ) and
-            result instanceof ExternalStringKind
+        (
+            name = "getHeader" or
+            name = "getCookie" or
+            name = "getUser" or
+            name = "getPassword"
+        ) and
+        result instanceof ExternalStringKind
     }
-
 }
 
-
 class TwistedRequestSource extends TaintSource {
+    TwistedRequestSource() { isTwistedRequestInstance(this) }
 
-    TwistedRequestSource() {
-        isTwistedRequestInstance(this)
-    }
-
-    override string toString() {
-        result = "Twisted request source"
-    }
-
-    override predicate isSourceOf(TaintKind kind) {
-        kind instanceof TwistedRequest
-    }
+    override string toString() { result = "Twisted request source" }
 
+    override predicate isSourceOf(TaintKind kind) { kind instanceof TwistedRequest }
 }

python/ql/src/semmle/python/web/twisted/Response.qll

@@ -1,5 +1,4 @@
 import python
-
 import semmle.python.security.TaintTracking
 import semmle.python.web.Http
 import semmle.python.security.strings.Basic
@@ -17,21 +16,17 @@ class TwistedResponse extends TaintSink {
         )
     }
 
-    override predicate sinks(TaintKind kind) {
-      kind instanceof ExternalStringKind
-    }
+    override predicate sinks(TaintKind kind) { kind instanceof ExternalStringKind }
 
-    override string toString() {
-        result = "Twisted response"
-    }
+    override string toString() { result = "Twisted response" }
 }
 
 /**
  * A sink of taint in the form of a "setter" method on a twisted request
  * object, which affects the properties of the subsequent response sent to this
  * request.
  */
- class TwistedRequestSetter extends HttpResponseTaintSink {
+class TwistedRequestSetter extends HttpResponseTaintSink {
     TwistedRequestSetter() {
         exists(CallNode call, ControlFlowNode node, string name |
             (
@@ -45,11 +40,7 @@ class TwistedResponse extends TaintSink {
         )
     }
 
-    override predicate sinks(TaintKind kind) {
-        kind instanceof ExternalStringKind
-    }
+    override predicate sinks(TaintKind kind) { kind instanceof ExternalStringKind }
 
-    override string toString() {
-        result = "Twisted request setter"
-    }
+    override string toString() { result = "Twisted request setter" }
 }

python/ql/src/semmle/python/web/twisted/Twisted.qll

@@ -1,5 +1,4 @@
 import python
-
 import semmle.python.security.TaintTracking
 
 private ClassValue theTwistedHttpRequestClass() {
@@ -10,9 +9,7 @@ private ClassValue theTwistedHttpResourceClass() {
     result = Value::named("twisted.web.resource.Resource")
 }
 
-ClassValue aTwistedRequestHandlerClass() {
-    result.getABaseType+() = theTwistedHttpResourceClass()
-}
+ClassValue aTwistedRequestHandlerClass() { result.getABaseType+() = theTwistedHttpResourceClass() }
 
 FunctionValue getTwistedRequestHandlerMethod(string name) {
     result = aTwistedRequestHandlerClass().declaredAttribute(name)
@@ -24,29 +21,32 @@ predicate isKnownRequestHandlerMethodName(string name) {
     name.matches("render_%")
 }
 
-/** Holds if `node` is likely to refer to an instance of the twisted
+/**
+ * Holds if `node` is likely to refer to an instance of the twisted
  * `Request` class.
  */
 predicate isTwistedRequestInstance(NameNode node) {
     node.pointsTo().getClass() = theTwistedHttpRequestClass()
     or
-    /* In points-to analysis cannot infer that a given object is an instance of
+    /*
+     * In points-to analysis cannot infer that a given object is an instance of
      * the `twisted.web.http.Request` class, we also include any parameter
      * called `request` that appears inside a subclass of a request handler
      * class, and the appropriate arguments of known request handler methods.
      */
+
     exists(Function func | func = node.getScope() |
         func.getEnclosingScope() = aTwistedRequestHandlerClass().getScope()
     ) and
     (
-    /* Any parameter called `request` */
-    node.getId() = "request" and
-    node.isParameter()
-    or
-    /* Any request parameter of a known request handler method */
-    exists(Function func | node.getScope() = func |
-        isKnownRequestHandlerMethodName(func.getName()) and
-        node.getNode() = func.getArg(1)
+        /* Any parameter called `request` */
+        node.getId() = "request" and
+        node.isParameter()
+        or
+        /* Any request parameter of a known request handler method */
+        exists(Function func | node.getScope() = func |
+            isKnownRequestHandlerMethodName(func.getName()) and
+            node.getNode() = func.getArg(1)
         )
     )
 }