Skip to content

Commit a57308a

Browse files
committed
Fix SnakeYaml query to account for Yaml subclasses and compose methods
1 parent c28856d commit a57308a

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

java/ql/src/semmle/code/java/frameworks/SnakeYaml.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class SafeSnakeYamlConstruction extends ClassInstanceExpr {
3939
* The class `org.yaml.snakeyaml.Yaml`.
4040
*/
4141
class Yaml extends RefType {
42-
Yaml() { this.hasQualifiedName("org.yaml.snakeyaml", "Yaml") }
42+
Yaml() { this.getASupertype*().hasQualifiedName("org.yaml.snakeyaml", "Yaml") }
4343
}
4444

4545
private class SafeYamlConstructionFlowConfig extends DataFlow2::Configuration {
@@ -71,7 +71,7 @@ private class SnakeYamlParse extends MethodAccess {
7171
SnakeYamlParse() {
7272
exists(Method m |
7373
m.getDeclaringType() instanceof Yaml and
74-
(m.hasName("load") or m.hasName("loadAll") or m.hasName("loadAs") or m.hasName("parse")) and
74+
(m.hasName("compose") or m.hasName("composeAll") or m.hasName("load") or m.hasName("loadAll") or m.hasName("loadAs") or m.hasName("parse")) and
7575
m = this.getMethod()
7676
)
7777
}

0 commit comments

Comments
 (0)