Java: Accept dispatch precision improvement.

aschackmull · aschackmull · commit a72cf56a0508 · 2026-02-23T15:09:57.000+01:00
diff --git a/java/ql/test/library-tests/switch-default-impossible-dispatch/Test.java b/java/ql/test/library-tests/switch-default-impossible-dispatch/Test.java
@@ -25,7 +25,7 @@ public static void test(int unknown, int alsoUnknown) {
 
     switch(i) {
       case C1 c1 -> { }
-      case null, default -> i.take(source()); // Can't call C1.take (but we don't currently notice)
+      case null, default -> i.take(source()); // Can't call C1.take
     }
 
     switch(i) {
@@ -55,7 +55,7 @@ case WrapperWrapper(Wrapper(String s)) -> { }
 
     switch(i) {
       case C1 c1: break;
-      case null: default: i.take(source()); // Can't call C1.take (but we don't currently notice)
+      case null: default: i.take(source()); // Can't call C1.take
     }
 
     switch(i) {
diff --git a/java/ql/test/library-tests/switch-default-impossible-dispatch/test.expected b/java/ql/test/library-tests/switch-default-impossible-dispatch/test.expected
@@ -5,7 +5,6 @@
 | Test.java:23:25:23:32 | source(...) | Test.java:8:65:8:65 | x |
 | Test.java:23:25:23:32 | source(...) | Test.java:9:74:9:74 | x |
 | Test.java:23:25:23:32 | source(...) | Test.java:10:82:10:82 | x |
-| Test.java:28:36:28:43 | source(...) | Test.java:7:65:7:65 | x |
 | Test.java:28:36:28:43 | source(...) | Test.java:8:65:8:65 | x |
 | Test.java:28:36:28:43 | source(...) | Test.java:9:74:9:74 | x |
 | Test.java:28:36:28:43 | source(...) | Test.java:10:82:10:82 | x |
@@ -26,7 +25,6 @@
 | Test.java:53:25:53:32 | source(...) | Test.java:8:65:8:65 | x |
 | Test.java:53:25:53:32 | source(...) | Test.java:9:74:9:74 | x |
 | Test.java:53:25:53:32 | source(...) | Test.java:10:82:10:82 | x |
-| Test.java:58:34:58:41 | source(...) | Test.java:7:65:7:65 | x |
 | Test.java:58:34:58:41 | source(...) | Test.java:8:65:8:65 | x |
 | Test.java:58:34:58:41 | source(...) | Test.java:9:74:9:74 | x |
 | Test.java:58:34:58:41 | source(...) | Test.java:10:82:10:82 | x |

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public static void test(int unknown, int alsoUnknown) {`
`25`	`25`
`26`	`26`	`switch(i) {`
`27`	`27`	`case C1 c1 -> { }`
`28`		`- case null, default -> i.take(source()); // Can't call C1.take (but we don't currently notice)`
	`28`	`+ case null, default -> i.take(source()); // Can't call C1.take`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`switch(i) {`
`@@ -55,7 +55,7 @@ case WrapperWrapper(Wrapper(String s)) -> { }`
`55`	`55`
`56`	`56`	`switch(i) {`
`57`	`57`	`case C1 c1: break;`
`58`		`- case null: default: i.take(source()); // Can't call C1.take (but we don't currently notice)`
	`58`	`+ case null: default: i.take(source()); // Can't call C1.take`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`switch(i) {`