unlimited repetition of a wildcard is also a wildcard

erik-krogh · erik-krogh · commit d07c71c99de5 · 2021-04-28T11:46:35.000+02:00
diff --git a/javascript/ql/src/semmle/javascript/Regexp.qll b/javascript/ql/src/semmle/javascript/Regexp.qll
@@ -1078,6 +1078,12 @@ module RegExp {
       not cls.isInverted() and
       cls.getAChild().(RegExpCharacterClassEscape).getValue().isUppercase()
     )
+    or
+    // an unlimited number of wildcards, is also a wildcard.
+    exists(InfiniteRepetitionQuantifier q |
+      term = q and
+      isWildcardLike(q.getAChild())
+    )
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -1078,6 +1078,12 @@ module RegExp {`
`1078`	`1078`	`not cls.isInverted() and`
`1079`	`1079`	`cls.getAChild().(RegExpCharacterClassEscape).getValue().isUppercase()`
`1080`	`1080`	`)`
	`1081`	`+ or`
	`1082`	`+ // an unlimited number of wildcards, is also a wildcard.`
	`1083`	`+ exists(InfiniteRepetitionQuantifier q \|`
	`1084`	`+ term = q and`
	`1085`	`+ isWildcardLike(q.getAChild())`
	`1086`	`+ )`
`1081`	`1087`	`}`
`1082`	`1088`
`1083`	`1089`	`/**`