Skip to content

Commit ea7fede

Browse files
paldepindpaldepind
committed
Revert "Ruby: Accept different consistency errors"
This reverts commit 2a7ebd1.
1 parent 2a7ebd1 commit ea7fede

File tree

3 files changed

+24
-31
lines changed

3 files changed

+24
-31
lines changed

‎ruby/ql/test/library-tests/ast/CONSISTENCY/AstConsistency.expected‎

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
1-
missingParent
2-
| control/conditionals.rb:137:6:138:7 | ( ... ) | ParenthesizedExpr |
3-
extractionWarning
4-
| control/conditionals.rb:94:5:94:4 | A parse error occurred (expected identifier symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. |
5-
| control/conditionals.rb:94:5:95:8 | Missing value for field: binary::left |
6-
| control/conditionals.rb:119:7:119:6 | A parse error occurred (expected identifier symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. |
7-
| control/conditionals.rb:119:7:120:6 | Missing value for field: binary::left |
8-
| control/conditionals.rb:128:8:128:7 | A parse error occurred (expected identifier symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. |
9-
| control/conditionals.rb:128:8:129:6 | Missing value for field: binary::left |
10-
| control/conditionals.rb:136:5:136:4 | A parse error occurred (expected identifier symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. |
11-
| control/conditionals.rb:136:5:138:7 | Missing value for field: binary::left |
12-
| operations/operations.rb:91:8:91:7 | A parse error occurred (expected identifier symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. |
13-
| operations/operations.rb:91:8:92:6 | Missing value for field: binary::left |
14-
| operations/operations.rb:103:11:103:10 | A parse error occurred (expected identifier symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. |
15-
| operations/operations.rb:103:11:104:8 | Missing value for field: binary::left |
1+
[VALUE_NOT_IN_TYPE] predicate ruby_body_statement_child(@ruby_body_statement ruby_body_statement, int index, @ruby_body_statement_child_type child): Value -16765701 of field child is not in type @ruby_body_statement_child_type. Appears in tuple (-16765709,1,-16765701)
2+
[VALUE_NOT_IN_TYPE] predicate ruby_parenthesized_statements_child(@ruby_parenthesized_statements ruby_parenthesized_statements, int index, @ruby_parenthesized_statements_child_type child): Value -16771086 of field child is not in type @ruby_parenthesized_statements_child_type. Appears in tuple (-16771091,1,-16771086)
3+
[VALUE_NOT_IN_TYPE] predicate ruby_program_child(@ruby_program ruby_program, int index, @ruby_program_child_type child): Value -16765775 of field child is not in type @ruby_program_child_type. Appears in tuple (-16766395,65,-16765775)
4+
[VALUE_NOT_IN_TYPE] predicate ruby_then_child(@ruby_then ruby_then, int index, @ruby_then_child_type child): Value -16771206 of field child is not in type @ruby_then_child_type. Appears in tuple (-16771207,0,-16771206)
5+
[VALUE_NOT_IN_TYPE] predicate ruby_then_child(@ruby_then ruby_then, int index, @ruby_then_child_type child): Value -16771120 of field child is not in type @ruby_then_child_type. Appears in tuple (-16771121,0,-16771120)
6+
[VALUE_NOT_IN_TYPE] predicate ruby_then_child(@ruby_then ruby_then, int index, @ruby_then_child_type child): Value -16771054 of field child is not in type @ruby_then_child_type. Appears in tuple (-16771055,0,-16771054)
7+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): Value -16771206 of field parent is not in type @ruby_ast_node. Appears in tuple (-16771203,-16771206,0)
8+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): Value -16771206 of field parent is not in type @ruby_ast_node. Appears in tuple (-16771201,-16771206,1)
9+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): Value -16771120 of field parent is not in type @ruby_ast_node. Appears in tuple (-16771117,-16771120,0)
10+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): Value -16771120 of field parent is not in type @ruby_ast_node. Appears in tuple (-16771115,-16771120,1)
11+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): Value -16771086 of field parent is not in type @ruby_ast_node. Appears in tuple (-16771083,-16771086,0)
12+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): More errors, not displayed. There are 12 values of field parent that are not in type @ruby_ast_node for a relation of size 6113

‎ruby/ql/test/library-tests/ast/control/CONSISTENCY/AstConsistency.expected‎

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
1-
missingParent
2-
| conditionals.rb:137:6:138:7 | ( ... ) | ParenthesizedExpr |
3-
extractionWarning
4-
| conditionals.rb:94:5:94:4 | A parse error occurred (expected identifier symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. |
5-
| conditionals.rb:94:5:95:8 | Missing value for field: binary::left |
6-
| conditionals.rb:119:7:119:6 | A parse error occurred (expected identifier symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. |
7-
| conditionals.rb:119:7:120:6 | Missing value for field: binary::left |
8-
| conditionals.rb:128:8:128:7 | A parse error occurred (expected identifier symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. |
9-
| conditionals.rb:128:8:129:6 | Missing value for field: binary::left |
10-
| conditionals.rb:136:5:136:4 | A parse error occurred (expected identifier symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. |
11-
| conditionals.rb:136:5:138:7 | Missing value for field: binary::left |
1+
[VALUE_NOT_IN_TYPE] predicate ruby_body_statement_child(@ruby_body_statement ruby_body_statement, int index, @ruby_body_statement_child_type child): Value -16776522 of field child is not in type @ruby_body_statement_child_type. Appears in tuple (-16776530,1,-16776522)
2+
[VALUE_NOT_IN_TYPE] predicate ruby_program_child(@ruby_program ruby_program, int index, @ruby_program_child_type child): Value -16776596 of field child is not in type @ruby_program_child_type. Appears in tuple (-16777216,65,-16776596)
3+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): Value -16776596 of field parent is not in type @ruby_ast_node. Appears in tuple (-16776593,-16776596,0)
4+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): Value -16776596 of field parent is not in type @ruby_ast_node. Appears in tuple (-16776591,-16776596,1)
5+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): Value -16776522 of field parent is not in type @ruby_ast_node. Appears in tuple (-16776519,-16776522,0)
6+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): Value -16776522 of field parent is not in type @ruby_ast_node. Appears in tuple (-16776517,-16776522,1)

‎ruby/ql/test/library-tests/ast/operations/CONSISTENCY/AstConsistency.expected‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
extractionWarning
2-
| operations.rb:91:8:91:7 | A parse error occurred (expected identifier symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. |
3-
| operations.rb:91:8:92:6 | Missing value for field: binary::left |
4-
| operations.rb:103:11:103:10 | A parse error occurred (expected identifier symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. |
5-
| operations.rb:103:11:104:8 | Missing value for field: binary::left |
1+
[VALUE_NOT_IN_TYPE] predicate ruby_body_statement_child(@ruby_body_statement ruby_body_statement, int index, @ruby_body_statement_child_type child): Value -16776522 of field child is not in type @ruby_body_statement_child_type. Appears in tuple (-16776530,1,-16776522)
2+
[VALUE_NOT_IN_TYPE] predicate ruby_program_child(@ruby_program ruby_program, int index, @ruby_program_child_type child): Value -16776596 of field child is not in type @ruby_program_child_type. Appears in tuple (-16777216,65,-16776596)
3+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): Value -16776596 of field parent is not in type @ruby_ast_node. Appears in tuple (-16776593,-16776596,0)
4+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): Value -16776596 of field parent is not in type @ruby_ast_node. Appears in tuple (-16776591,-16776596,1)
5+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): Value -16776522 of field parent is not in type @ruby_ast_node. Appears in tuple (-16776519,-16776522,0)
6+
[VALUE_NOT_IN_TYPE] predicate ruby_ast_node_parent(@ruby_ast_node node, @ruby_ast_node parent, int parent_index): Value -16776522 of field parent is not in type @ruby_ast_node. Appears in tuple (-16776517,-16776522,1)

0 commit comments

Comments
 (0)