C#: Add test showing false positive

calumgrant · calumgrant · commit f23438ea6566 · 2020-01-28T11:48:59.000Z
diff --git a/csharp/ql/test/query-tests/Likely Bugs/DangerousNonShortCircuitLogic/DangerousNonShortCircuitLogic.cs b/csharp/ql/test/query-tests/Likely Bugs/DangerousNonShortCircuitLogic/DangerousNonShortCircuitLogic.cs
@@ -20,6 +20,8 @@ void M()
         var b = true;
         b &= c.Method(); // GOOD
         b |= c[0]; // GOOD
+
+        if (c == null | c.Method(out _)) ; // GOOD (false positive)
     }
 
     class C
@@ -28,6 +30,7 @@ class C
         public string Property { get; set; }
         public bool this[int i] { get { return false; } set { } }
         public bool Method() { return false; }
+        public bool Method(out int x) { x = 0; return false; }
     }
 }
 
diff --git a/csharp/ql/test/query-tests/Likely Bugs/DangerousNonShortCircuitLogic/DangerousNonShortCircuitLogic.expected b/csharp/ql/test/query-tests/Likely Bugs/DangerousNonShortCircuitLogic/DangerousNonShortCircuitLogic.expected
@@ -2,3 +2,4 @@
 | DangerousNonShortCircuitLogic.cs:16:13:16:40 | ... \| ... | Potentially dangerous use of non-short circuit logic. |
 | DangerousNonShortCircuitLogic.cs:17:13:17:28 | ... \| ... | Potentially dangerous use of non-short circuit logic. |
 | DangerousNonShortCircuitLogic.cs:18:13:18:34 | ... \| ... | Potentially dangerous use of non-short circuit logic. |
+| DangerousNonShortCircuitLogic.cs:24:13:24:39 | ... \| ... | Potentially dangerous use of non-short circuit logic. |

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,8 @@ void M()`
`20`	`20`	`var b = true;`
`21`	`21`	`b &= c.Method(); // GOOD`
`22`	`22`	`b \|= c[0]; // GOOD`
	`23`	`+`
	`24`	`+ if (c == null \| c.Method(out _)) ; // GOOD (false positive)`
`23`	`25`	`}`
`24`	`26`
`25`	`27`	`class C`
`@@ -28,6 +30,7 @@ class C`
`28`	`30`	`public string Property { get; set; }`
`29`	`31`	`public bool this[int i] { get { return false; } set { } }`
`30`	`32`	`public bool Method() { return false; }`
	`33`	`+ public bool Method(out int x) { x = 0; return false; }`
`31`	`34`	`}`
`32`	`35`	`}`
`33`	`36`