add pragma to internalBlocks predicate to fix performance

erik-krogh · erik-krogh · commit f537e28389c3 · 2019-12-11T15:19:30.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll b/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll
@@ -303,6 +303,7 @@ abstract class BarrierGuardNode extends DataFlow::Node {
    *
    * INTERNAL: this predicate should only be used from within `blocks(boolean, Expr)`.
    */
+  pragma[noinline,nomagic]
   predicate internalBlocks(DataFlow::Node nd, string label) {
     // 1) `nd` is a use of a refinement node that blocks its input variable
     exists(SsaRefinementNode ref, boolean outcome |
diff --git a/javascript/ql/src/semmle/javascript/security/dataflow/ExceptionXss.qll b/javascript/ql/src/semmle/javascript/security/dataflow/ExceptionXss.qll
@@ -125,7 +125,6 @@ module ExceptionXss {
 
     override predicate isSanitizer(DataFlow::Node node) { node instanceof Xss::Shared::Sanitizer }
 
-    cached
     override predicate isAdditionalFlowStep(
       DataFlow::Node pred, DataFlow::Node succ, DataFlow::FlowLabel inlbl,
       DataFlow::FlowLabel outlbl

Original file line number	Diff line number	Diff line change
`@@ -303,6 +303,7 @@ abstract class BarrierGuardNode extends DataFlow::Node {`
`303`	`303`	`*`
`304`	`304`	* INTERNAL: this predicate should only be used from within `blocks(boolean, Expr)`.
`305`	`305`	`*/`
	`306`	`+ pragma[noinline,nomagic]`
`306`	`307`	`predicate internalBlocks(DataFlow::Node nd, string label) {`
`307`	`308`	// 1) `nd` is a use of a refinement node that blocks its input variable
`308`	`309`	`exists(SsaRefinementNode ref, boolean outcome \|`