Make 'log' field non-nullable again.

Author: asgerf

extensions/ql-vscode/src/query-history/store/query-history-local-query-dto-mapper.ts

@@ -32,13 +32,15 @@ export function mapLocalQueryItemToDomainModel(
     localQuery.failureReason,
     localQuery.completedQuery &&
       mapCompletedQueryInfoToDomainModel(localQuery.completedQuery),
-    {
-      log: localQuery.evalLogLocation,
-      humanReadableSummary: localQuery.evalLogSummaryLocation,
-      jsonSummary: localQuery.jsonEvalLogSummaryLocation,
-      summarySymbols: localQuery.evalLogSummarySymbolsLocation,
-      endSummary: undefined,
-    },
+    localQuery.evalLogLocation
+      ? {
+          log: localQuery.evalLogLocation,
+          humanReadableSummary: localQuery.evalLogSummaryLocation,
+          jsonSummary: localQuery.jsonEvalLogSummaryLocation,
+          summarySymbols: localQuery.evalLogSummarySymbolsLocation,
+          endSummary: undefined,
+        }
+      : undefined,
   );
 }
 

extensions/ql-vscode/src/query-results.ts

@@ -200,13 +200,7 @@ export class LocalQueryInfo {
     private cancellationSource?: CancellationTokenSource, // used to cancel in progress queries
     public failureReason?: string,
     public completedQuery?: CompletedQueryInfo,
-    public evalutorLogPaths: EvaluatorLogPaths = {
-      log: undefined,
-      humanReadableSummary: undefined,
-      endSummary: undefined,
-      jsonSummary: undefined,
-      summarySymbols: undefined,
-    },
+    public evalutorLogPaths?: EvaluatorLogPaths,
   ) {
     /**/
   }

extensions/ql-vscode/src/run-queries-shared.ts

@@ -45,7 +45,7 @@ import type { ProgressCallback } from "./common/vscode/progress";
  * Holds the paths to the various structured log summary files generated for a query evaluation.
  */
 export interface EvaluatorLogPaths {
-  log: string | undefined;
+  log: string;
   humanReadableSummary: string | undefined;
   endSummary: string | undefined;
   jsonSummary: string | undefined;