Skip to content

Commit a358ffe

Browse files
authored
Merge pull request #482 from globocom/develop
Develop
2 parents 620ce76 + 7c5eeda commit a358ffe

4 files changed

Lines changed: 19 additions & 10 deletions

File tree

networkapi/api_deploy/facade.py

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ def _applyconfig(equipment, filename, equipment_access=None, source_server=None,
5757
Raises:
5858
"""
5959

60+
log.info("Applying configuration in equipment {} with filename {}...".format(equipment, filename))
61+
6062
if equipment.maintenance is True:
6163
return 'Equipment is in maintenance mode. No action taken.'
6264

@@ -71,15 +73,18 @@ def _applyconfig(equipment, filename, equipment_access=None, source_server=None,
7173
# if tipo_acesso is None:
7274
# return 'Equipment has no Access.'
7375

74-
equip_plugin = PluginFactory.factory(equipment)
75-
equip_plugin.connect()
76-
equip_plugin.ensure_privilege_level()
77-
vrf = equip_plugin.equipment_access.vrf.internal_name if equip_plugin.equipment_access.vrf else None
78-
equip_output = equip_plugin.copyScriptFileToConfig(filename, use_vrf=vrf)
79-
equip_plugin.close()
80-
81-
return equip_output
82-
76+
try:
77+
equip_plugin = PluginFactory.factory(equipment)
78+
equip_plugin.connect()
79+
equip_plugin.ensure_privilege_level()
80+
vrf = equip_plugin.equipment_access.vrf.internal_name if equip_plugin.equipment_access.vrf else None
81+
equip_output = equip_plugin.copyScriptFileToConfig(filename, use_vrf=vrf)
82+
equip_plugin.close()
83+
84+
return equip_output
85+
except Exception, e:
86+
log.error("Error applying configuration in equipment {}: {}".format(equipment, e))
87+
raise api_exceptions.NetworkAPIException(e)
8388

8489
def create_file_from_script(script, prefix_name=''):
8590
"""Creates a file with script content

networkapi/api_network/facade/v1.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,8 @@ def remove_deploy_networkIPv4_configuration(user, networkipv4, equipment_list):
193193
Returns: List with status of equipments output
194194
"""
195195

196+
log.debug("remove_deploy_networkIPv4_configuration")
197+
196198
data = dict()
197199

198200
# lock network id to prevent multiple requests to same id

networkapi/api_network/facade/v3/networkv4.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,8 @@ def undeploy_networkipv4(network_id, user, force=False):
160160
Returns: List with status of equipments output
161161
"""
162162

163+
log.debug('undeploy_networkipv4')
164+
163165
try:
164166
netv4_obj = get_networkipv4_by_id(network_id)
165167

networkapi/api_network/views/v1.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ def networkIPv4_deploy(request, network_id):
371371

372372
except Exception, exception:
373373
log.error(exception)
374-
raise api_exceptions.NetworkAPIException()
374+
raise api_exceptions.NetworkAPIException(exception)
375375

376376

377377
@api_view(['GET'])

0 commit comments

Comments
 (0)