Skip to content

Commit 575aed5

Browse files
committed
chore(gooddata-sdk): bump code-convertors to 11.35.0a2 for HLL attr
11.35.0a2 carries the WASM fix that emits `reference.type="attribute"` for APPROXIMATE_COUNT aggregated_facts whose `assigned_to` points at an attribute. The previously-xfailed AAC round-trip now passes naturally; xfail decorator and the matching gap notes in the module/test docstrings are removed. risk: low
1 parent a525014 commit 575aed5

3 files changed

Lines changed: 7 additions & 20 deletions

File tree

packages/gooddata-sdk/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dependencies = [
3434
"brotli==1.2.0",
3535
"requests~=2.32.0",
3636
"python-dotenv>=1.0.0,<2.0.0",
37-
"gooddata-code-convertors>=11.33.0",
37+
"gooddata-code-convertors>=11.35.0a2",
3838
]
3939
classifiers = [
4040
"Development Status :: 5 - Production/Stable",

packages/gooddata-sdk/tests/catalog/unit_tests/test_aac_agg_aware.py

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
for the three new shapes that aggregate-aware LDMs introduce:
66
77
- AUXILIARY datasets (no physical mapping, synthetic identity attributes).
8-
- NORMAL pre-aggregation datasets with `aggregated_facts` (SUM-of-fact today;
9-
see the xfail test for the APPROXIMATE_COUNT-of-attribute gap).
8+
- NORMAL pre-aggregation datasets with `aggregated_facts` (SUM-of-fact and
9+
APPROXIMATE_COUNT-of-attribute for HLL synopses).
1010
- NORMAL synthesized dim datasets backed by a `sql:` block.
1111
1212
These tests guard the **SDK side** of the AAC convertor pipeline; the
@@ -15,7 +15,6 @@
1515

1616
from __future__ import annotations
1717

18-
import pytest
1918
import yaml
2019
from gooddata_sdk.catalog.workspace.aac import (
2120
aac_dataset_to_declarative,
@@ -142,23 +141,11 @@ def test_synthesized_dim_with_sql_round_trips_through_aac() -> None:
142141
assert out_attrs[0]["sourceColumn"] == "country"
143142

144143

145-
@pytest.mark.xfail(
146-
reason=(
147-
"WASM convertor (gooddata-code-convertors 11.33.x/11.34.x) emits "
148-
"reference.type='fact' for APPROXIMATE_COUNT aggregated_facts even when "
149-
"`assigned_to` points at an attribute target. Fix lives in "
150-
"../gdc-ui sdk-code-convertors; remove this xfail once a WASM bump "
151-
"carrying the fix lands."
152-
),
153-
strict=True,
154-
)
155144
def test_pre_aggregation_approximate_count_attribute_target_round_trips() -> None:
156145
"""HLL APPROXIMATE_COUNT references an attribute, not a fact.
157146
158147
The platform requires `aggregatedFacts[].sourceFactReference.reference.type
159-
== "attribute"` for HLL synopses (gdc-nas CQ-2147). The current WASM build
160-
produces `"fact"` here regardless of input — captured as xfail so the test
161-
suite flips green automatically when the WASM is fixed.
148+
== "attribute"` for HLL synopses (gdc-nas CQ-2147).
162149
"""
163150
aac = {
164151
"type": "dataset",

uv.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)