Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.
This repository was archived by the owner on May 15, 2025. It is now read-only.

Interfaces are package private their implementations are not #29

@Lacritz

Description

@Lacritz

Hi Folks,

I have noticed that the UsersService interface is package private while the implementation is not. This leads to an unintuitive API.
The entry point for all of the identity services (UsersService, GroupsService) are the IdentityService interface and the regarding implementation IdentityServiceImpl.

To be more convenient - you should either make GroupsServiceImpl and UsersServiceImpl package private or the regarding interfaces public.

Please verify - I would add a pull requests with the changes necessary.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions