Commit 38f810f
fix: guard empty rubric text in substring fallback + debug logging
Address reviewer feedback on #6072:
- Guard `if not rubric and normalized_rubric_text:` prevents empty
judge Property: lines from matching every rubric via substring
- Guard `if ct and` prevents empty rubric keys from matching
- Add logger.debug when substring fallback rescues a match to track
judge drift in eval logs
- Add test_empty_property_text_does_not_match test case
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 9bb59fc commit 38f810f
2 files changed
Lines changed: 15 additions & 2 deletions
File tree
- src/google/adk/evaluation
- tests/unittests/evaluation
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
417 | 417 | | |
418 | 418 | | |
419 | 419 | | |
420 | | - | |
| 420 | + | |
421 | 421 | | |
422 | 422 | | |
423 | 423 | | |
424 | | - | |
| 424 | + | |
425 | 425 | | |
426 | 426 | | |
427 | 427 | | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
428 | 433 | | |
429 | 434 | | |
430 | 435 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
771 | 771 | | |
772 | 772 | | |
773 | 773 | | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
0 commit comments