Commit e29c0f3
committed
fix: guard empty rubric text in substring fallback + debug logging
Address reviewer feedback on #6072:
- Guard `if not rubric and normalized_rubric_text:` prevents empty
judge Property: lines from matching every rubric via substring
- Guard `if ct and` prevents empty rubric keys from matching
- Add logger.debug when substring fallback rescues a match to track
judge drift in eval logs
- Add test_empty_property_text_does_not_match test case1 parent c7fca2c commit e29c0f3
2 files changed
Lines changed: 15 additions & 2 deletions
File tree
- src/google/adk/evaluation
- tests/unittests/evaluation
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
431 | 431 | | |
432 | 432 | | |
433 | 433 | | |
434 | | - | |
| 434 | + | |
435 | 435 | | |
436 | 436 | | |
437 | 437 | | |
438 | | - | |
| 438 | + | |
439 | 439 | | |
440 | 440 | | |
441 | 441 | | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
442 | 447 | | |
443 | 448 | | |
444 | 449 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
808 | 808 | | |
809 | 809 | | |
810 | 810 | | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
0 commit comments