Skip to content

Commit 5806d30

Browse files
jckingcopybara-github
authored andcommitted
Update conformance test skip list
PiperOrigin-RevId: 912656156
1 parent ddcece1 commit 5806d30

2 files changed

Lines changed: 23 additions & 3 deletions

File tree

conformance/BUILD

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,26 @@ _TESTS_TO_SKIP = [
201201
# precision to preserve value. Not available on older compilers where we just use absl::Format.
202202
# We should probably update the spec to allow different formats that parse to the same value.
203203
"conversions/string/double_hard",
204+
205+
# Recent changes
206+
"proto2/set_null/repeated_field_timestamp_null_pruned",
207+
"proto2/set_null/repeated_field_duration_null_pruned",
208+
"proto2/set_null/repeated_field_wrapper_null_pruned",
209+
"proto2/set_null/map_timestamp_null_pruned",
210+
"proto2/set_null/map_duration_null_pruned",
211+
"proto2/set_null/map_wrapper_null_pruned",
212+
"proto3/set_null/repeated_field_timestamp_null_pruned",
213+
"proto3/set_null/repeated_field_duration_null_pruned",
214+
"proto3/set_null/repeated_field_wrapper_null_pruned",
215+
"proto3/set_null/map_timestamp_null_pruned",
216+
"proto3/set_null/map_duration_null_pruned",
217+
"proto3/set_null/map_wrapper_null_pruned",
218+
"string_ext/format/default precision for fixed-point clause with int",
219+
"string_ext/format/default precision for fixed-point clause with uint",
220+
"string_ext/format/default precision for scientific notation with int",
221+
"string_ext/format/default precision for scientific notation with uint",
222+
"namespace/namespace_shadowing/basic",
223+
"namespace/namespace_shadowing/comprehension_shadowing_namespaced_selector_disambiguation",
204224
]
205225

206226
_TESTS_TO_SKIP_MODERN = _TESTS_TO_SKIP

conformance/run.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def _conformance_test_args(modern, optimize, recursive, select_opt, skip_check,
7070
args.append("--skip_check")
7171
else:
7272
args.append("--noskip_check")
73-
args.append("--skip_tests={}".format(",".join(_expand_tests_to_skip(skip_tests))))
73+
args.append("--skip_tests=\"{}\"".format(",".join(_expand_tests_to_skip(skip_tests))))
7474
if dashboard:
7575
args.append("--dashboard")
7676
return args
@@ -80,8 +80,8 @@ def _conformance_test(name, data, modern, optimize, recursive, select_opt, skip_
8080
name = _conformance_test_name(name, optimize, recursive),
8181
args = _conformance_test_args(modern, optimize, recursive, select_opt, skip_check, skip_tests, dashboard) + ["$(location " + test + ")" for test in data] + select(
8282
{
83-
"@platforms//os:windows": ["--skip_tests={}".format(",".join(skip_tests + _TESTS_TO_SKIP_WINDOWS))],
84-
"//conditions:default": ["--skip_tests={}".format(",".join(skip_tests))],
83+
"@platforms//os:windows": ["--skip_tests=\"{}\"".format(",".join(skip_tests + _TESTS_TO_SKIP_WINDOWS))],
84+
"//conditions:default": ["--skip_tests=\"{}\"".format(",".join(skip_tests))],
8585
},
8686
),
8787
data = data,

0 commit comments

Comments
 (0)