Chrome iOS - AR button not showing

[danilokrulj]

When opening model-viewer content in Chrome on iOS devices, the AR button doesn't show at all. Tested on multiple pages and multiple iOS devices.

It appears to be an issue with the latest modelviewer version, when i changed to 4.2.0 the button appeared.

[Frank3K]

I think the regression was introduced in #5162.

It works again when these lines:

model-viewer/packages/model-viewer/src/features/ar.ts

Lines 246 to 249 in f47db92

	if (value === 'quick-look' && IS_AR_QUICKLOOK_CANDIDATE &&
	!IS_IOS_GSA && (!IS_IOS_THIRDPARTY || this.iosSrc != null)) {
	arMode = ARMode.QUICK_LOOK;
	break;

are changed to:

if (value === 'quick-look' && IS_AR_QUICKLOOK_CANDIDATE && !IS_IOS_GSA) {
  arMode = ARMode.QUICK_LOOK;
  break;
}

@diegoteran would you mind explaining the intent behind #5162? Specifically: was requiring ios-src on third-party iOS browsers a deliberate choice or is the hidden AR button an unintended regression? Happy to open a PR if a fix is welcome.

[diegoteran]

I think the regression was introduced in #5162.

It works again when these lines:

model-viewer/packages/model-viewer/src/features/ar.ts

Lines 246 to 249 in f47db92

if (value === 'quick-look' && IS_AR_QUICKLOOK_CANDIDATE &&
!IS_IOS_GSA && (!IS_IOS_THIRDPARTY || this.iosSrc != null)) {
arMode = ARMode.QUICK_LOOK;
break;
are changed to:

if (value === 'quick-look' && IS_AR_QUICKLOOK_CANDIDATE && !IS_IOS_GSA) {
arMode = ARMode.QUICK_LOOK;
break;
}
@diegoteran would you mind explaining the intent behind #5162? Specifically: was requiring ios-src on third-party iOS browsers a deliberate choice or is the hidden AR button an unintended regression? Happy to open a PR if a fix is welcome.

Thank you, I'd appreciate the PR. A lot of Google work at the moment.

[Frank3K]

Thank you, I'd appreciate the PR. A lot of Google work at the moment.

Done: #5188.